lmadsen scorecard cleanup (#135)

* Post-refactor clean up

Initial round of post-refactor clean up based on operator-sdk 0.19.4 and the
new generate commands. Updates the manifests and metadata per the new release
of operator-sdk and also validates that the scorecard can be run. Adjustments
made based on the scorecard recommendations were made. More to come.

* Set default channel to 'latest'

* Align metadata to new default channel of latest for HEAD

* Address most of the operator-sdk scorecard findings

Author: leifmadsen

.osdk-scorecard.yaml

@@ -1,12 +1,11 @@
 scorecard:
   version: v1alpha2
   output: text
-  bundle: deploy/olm-catalog/service-telemetry-operator/bundle/metadata
+  bundle: deploy/olm-catalog/service-telemetry-operator
   plugins:
     - basic:
         cr-manifest:
           - "deploy/crds/infra.watch_v1beta1_servicetelemetry_cr.yaml"
-        csv-path: "deploy/olm-catalog/service-telemetry-operator/manifests/service-telemetry-operator.clusterserviceversion.yaml"
     - olm:
         cr-manifest:
           - "deploy/crds/infra.watch_v1beta1_servicetelemetry_cr.yaml"

bundle.Dockerfile

@@ -6,9 +6,9 @@ LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/
 LABEL operators.operatorframework.io.bundle.package.v1=service-telemetry-operator
 LABEL operators.operatorframework.io.bundle.channels.v1=latest
 LABEL operators.operatorframework.io.bundle.channel.default.v1=latest
+LABEL operators.operatorframework.io.metrics.mediatype.v1=metrics+v1
 LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v0.19.4
 LABEL operators.operatorframework.io.metrics.project_layout=ansible
-LABEL operators.operatorframework.io.metrics.mediatype.v1=metrics+v1
 
 COPY deploy/olm-catalog/service-telemetry-operator/manifests /manifests/
 COPY deploy/olm-catalog/service-telemetry-operator/metadata /metadata/

deploy/olm-catalog/service-telemetry-operator/manifests/service-telemetry-operator.clusterserviceversion.yaml

@@ -106,6 +106,31 @@ spec:
         name: servicemonitors.monitoring.coreos.com
         version: v1
       specDescriptors:
+      - description: Alerting configuration
+        displayName: Alerting Configuration
+        path: alerting
+        x-descriptors:
+        - urn:alm:descriptor:com.tectonic.ui:hidden
+      - description: Backends configuration
+        displayName: Backends Configuration
+        path: backends
+        x-descriptors:
+        - urn:alm:descriptor:com.tectonic.ui:hidden
+      - description: Graphing configuration
+        displayName: Graphing Configuration
+        path: graphing
+        x-descriptors:
+        - urn:alm:descriptor:com.tectonic.ui:hidden
+      - description: highAvailability configuration
+        displayName: High Availability Configuration
+        path: highAvailability
+        x-descriptors:
+        - urn:alm:descriptor:com.tectonic.ui:hidden
+      - description: Transports configuration
+        displayName: Transports Configuration
+        path: transports
+        x-descriptors:
+        - urn:alm:descriptor:com.tectonic.ui:hidden
       - description: Enable Prometheus for metrics backend.
         displayName: Prometheus enabled
         path: backends.metrics.prometheus.enabled
@@ -203,7 +228,7 @@ spec:
         displayName: Conditions
         path: conditions
         x-descriptors:
-        - urn:alm:descriptor:io.kubernetes.conditions
+        - urn:alm:descriptor:io.kubernetes:conditions
       - description: Ephemeral storage used?
         displayName: Ephemeral storage used?
         path: ephemeralStorageEnabled.status
@@ -267,7 +292,7 @@ spec:
         displayName: Conditions
         path: conditions
         x-descriptors:
-        - urn:alm:descriptor:io.kubernetes.conditions
+        - urn:alm:descriptor:io.kubernetes:conditions
       version: v1alpha1
     required:
     - description: A declaration of a required Certificate