Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modification of search-box placeholder #947

Open
RFSH opened this issue Apr 15, 2022 · 0 comments
Open

Allow modification of search-box placeholder #947

RFSH opened this issue Apr 15, 2022 · 0 comments
Labels
annotation Anything related the annotations (adding new one or changing existing one) help wanted Intended for internal use for student workers tiny

Comments

@RFSH
Copy link
Member

RFSH commented Apr 15, 2022

Currently, we allow modification of search columns through the search-box property under search-definitions. To inform users about the modified behavior of search box, we're changing the placeholder to show a comma-separated list of displaynames.

As you can imagine, this can become very lengthy, and also, listing every column might not be helpful to users.

So as was proposed before, we should allow data modelers to define their own placeholder_markdown.

"tag:isrd.isi.edu,2019:source-definitions": {
  "sources": {
    ...
    "search-box": {
      "or": [...],
      "placeholder_markdown": "Shorter name for placeholder text in input",
    }
  }
}

As part of this, we should also add the computed placeholder (default value or the one customized with this annotation) to the first line of the tooltip for the search button. This is because the placeholder will disappear when you have a text in the search box, and we want users to be able to access it.

P.S. The original issue discussed adding a comment property, but we decided not to add it. We agreed that we don't want the tooltip we display when the content is long to differ from the content itself. We also didn't think allowing data modelers to modify the tooltip of the search button was needed.

@RFSH RFSH added discussion required requires a discussion before moving forward annotation Anything related the annotations (adding new one or changing existing one) labels Apr 15, 2022
@RFSH RFSH added the tiny label May 31, 2023
@RFSH RFSH added help wanted Intended for internal use for student workers and removed discussion required requires a discussion before moving forward labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation Anything related the annotations (adding new one or changing existing one) help wanted Intended for internal use for student workers tiny
Projects
None yet
Development

No branches or pull requests

1 participant