Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the source requirement for source-definitions #913

Open
RFSH opened this issue Oct 4, 2021 · 0 comments
Open

Relax the source requirement for source-definitions #913

RFSH opened this issue Oct 4, 2021 · 0 comments
Assignees
Labels
annotation Anything related the annotations (adding new one or changing existing one) discussion required requires a discussion before moving forward

Comments

@RFSH
Copy link
Member

RFSH commented Oct 4, 2021

Currently while defining a "source" in the source-definitions annotation, you MUST have the source property. This means,

  • You cannot use sourcekey to refer to other sources.
    • Work around: you have to copy/paste the same path multiple times.
    • Refer to this comment for more information.
  • You cannot define virtual columns (columns without any source).
    • Work around: given that you've already defined the name and presentation value, you can get around this by defining a local column as the source. Although this will have some side effects that might not be desirable. For example,
      • The duplicate detection in visible columns will use the column name. so the column cannot already be part of your visible-columns
      • In compact contexts, the column will be sortable and it will sort based on the local column (not what’s displayed)
      • If you define this in a * context, the regular column will show up in entry contexts

So we should see how we might want to allow this. Usage of sourcekey in source-definitions came up before in #909.

@RFSH RFSH self-assigned this Oct 4, 2021
@RFSH RFSH added annotation Anything related the annotations (adding new one or changing existing one) and removed enhancement labels Apr 5, 2022
@RFSH RFSH added the discussion required requires a discussion before moving forward label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation Anything related the annotations (adding new one or changing existing one) discussion required requires a discussion before moving forward
Projects
None yet
Development

No branches or pull requests

1 participant