Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if key is part of multisig before signing #39

Open
ebuchman opened this issue Jun 21, 2022 · 2 comments
Open

Check if key is part of multisig before signing #39

ebuchman opened this issue Jun 21, 2022 · 2 comments
Labels
enhancement New feature or request multisig Multisig tool

Comments

@ebuchman
Copy link
Member

This is ultimately an issue for the SDK but maybe there's something we can do in the meantime in multisig: cosmos/cosmos-sdk#12328

@andynog
Copy link
Contributor

andynog commented Jun 21, 2022

possibly use the keys show [multisig address] cli command and parse it

@oldremez
Copy link
Contributor

I have a little concern regarding using the keys show command. The thing is that if the keyring (or several of its elements) is password-protected (which might be a case for at least some users), even reading information about multisig might require password typing. Requiring typing passwords more times than it really necessary just for additional checks can bother users.
My proposal is to try getting data on-chain (via query account [multisig address]) by default. For multisig accounts this command returns the list of pubkeys so one can check if a specific address belongs to multisig.
Pros:

  1. Doesn't require keyring access
  2. Reliable way of getting data

Cons:

  1. Requires having an access to an RPC
  2. Requires multisig to have at least one transaction

So, my idea is that multisig tool can try to access data from the chain and if it fails (because of lack of RPC access or present transactions) then use data from the keyring.

@andynog andynog self-assigned this Aug 23, 2022
@andynog andynog added the enhancement New feature or request label Nov 17, 2022
@andynog andynog added this to the multisig v0.4.0 milestone Nov 17, 2022
@andynog andynog added the multisig Multisig tool label Nov 17, 2022
@mircea-c mircea-c removed this from the multisig - v0.5.0 milestone Jun 26, 2023
@andynog andynog removed their assignment Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multisig Multisig tool
Projects
None yet
Development

No branches or pull requests

4 participants