You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just noticed that the p2p protocol configuration now has a "transport" entry. consensus.p2p.transport and mempool.p2p.transport. The values can be tcp or quic.
However, the listen address is a Multiaddress and it inherently contains the protocol that is accepted. consensus.p2p.listen_addr = "/ipv4/0.0.0.0/udp/27000/quic-v1" or mempool.p2p.listen_addr = "ipv4/0.0.0.0/tcp/28000".
This is confusing and invalid configuration will yield "MultiAddrNotSupported" errors. For example the listen address can be configured for QUIC but the transport can be left on the default TCP.
I think the transport entry should be removed from the configuration and if the entry is needed in the code, it can be derived from the listen address.
The text was updated successfully, but these errors were encountered:
I just noticed that the p2p protocol configuration now has a "transport" entry.
consensus.p2p.transport
andmempool.p2p.transport
. The values can betcp
orquic
.However, the listen address is a Multiaddress and it inherently contains the protocol that is accepted.
consensus.p2p.listen_addr = "/ipv4/0.0.0.0/udp/27000/quic-v1"
ormempool.p2p.listen_addr = "ipv4/0.0.0.0/tcp/28000"
.This is confusing and invalid configuration will yield "MultiAddrNotSupported" errors. For example the listen address can be configured for QUIC but the transport can be left on the default TCP.
I think the transport entry should be removed from the configuration and if the entry is needed in the code, it can be derived from the listen address.
The text was updated successfully, but these errors were encountered: