Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport protocol configuration might be redundant #858

Open
greg-szabo opened this issue Feb 15, 2025 · 0 comments
Open

Transport protocol configuration might be redundant #858

greg-szabo opened this issue Feb 15, 2025 · 0 comments

Comments

@greg-szabo
Copy link
Member

I just noticed that the p2p protocol configuration now has a "transport" entry.
consensus.p2p.transport and mempool.p2p.transport. The values can be tcp or quic.

However, the listen address is a Multiaddress and it inherently contains the protocol that is accepted.
consensus.p2p.listen_addr = "/ipv4/0.0.0.0/udp/27000/quic-v1" or mempool.p2p.listen_addr = "ipv4/0.0.0.0/tcp/28000".

This is confusing and invalid configuration will yield "MultiAddrNotSupported" errors. For example the listen address can be configured for QUIC but the transport can be left on the default TCP.

I think the transport entry should be removed from the configuration and if the entry is needed in the code, it can be derived from the listen address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant