Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: Abstract over signature aggregation #831

Open
3 tasks
romac opened this issue Feb 5, 2025 · 0 comments
Open
3 tasks

code: Abstract over signature aggregation #831

romac opened this issue Feb 5, 2025 · 0 comments
Labels
code Code/implementation related
Milestone
Phase 5

Comments

@romac
Copy link
Member

romac commented Feb 5, 2025

Summary

Current naming of the CommitCertificate's aggregated_signature field is misleading as it's implemented as a Vec rather than true signature aggregation. Need to consider support for batch verification and actual signature aggregation.

malachite/code/crates/core-types/src/certificate.rs

Line 49 in 614a46c

pub aggregated_signature: AggregatedSignature<Ctx>, // TODO - type in context

Action items

  • Rename the field to signatures for now?
  • Make AggregatedSignature type generic through Context trait
  • Design interface for supporting:
    • Batch verification (ed25519)
    • True signature aggregation (BLS12381)
@romac romac added the code Code/implementation related label Feb 5, 2025
@romac romac added this to the Phase 5 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code Code/implementation related
Projects
None yet
Milestone
Phase 5
Development

No branches or pull requests
1 participant
@romac