chore: remove commented out impl Default

Author: tuantran1702

ibc-clients/ics07-tendermint/types/src/trust_threshold.rs

@@ -134,12 +134,6 @@ impl TryFrom<Fraction> for TrustThreshold {
     }
 }
 
-// impl Default for TrustThreshold {
-//     fn default() -> Self {
-//         Self::ONE_THIRD
-//     }
-// }
-
 impl Display for TrustThreshold {
     fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), FmtError> {
         write!(f, "{}/{}", self.numerator, self.denominator)

ibc-core/ics03-connection/types/src/version.rs

@@ -96,15 +96,6 @@ impl From<Version> for RawVersion {
     }
 }
 
-// impl Default for Version {
-//     fn default() -> Self {
-//         Version {
-//             identifier: "1".to_string(),
-//             features: vec!["ORDER_ORDERED".to_string(), "ORDER_UNORDERED".to_string()],
-//         }
-//     }
-// }
-
 impl Display for Version {
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
         write!(

ibc-core/ics24-host/types/src/identifiers/connection_id.rs

@@ -78,12 +78,6 @@ impl FromStr for ConnectionId {
     }
 }
 
-// impl Default for ConnectionId {
-//     fn default() -> Self {
-//         Self::new(0)
-//     }
-// }
-
 /// Equality check against string literal (satisfies &ConnectionId == &str).
 /// ```
 /// use core::str::FromStr;

ibc-core/ics24-host/types/src/path.rs

@@ -1169,7 +1169,7 @@ fn parse_upgrades(components: &[&str]) -> Option<Path> {
 #[cfg(test)]
 mod tests {
     use super::*;
-    const DUMMY_CLIENT_ID: &str = "07-tendermint-0";
+    const DEFAULT_CLIENT_ID: &str = "07-tendermint-0";
     #[rstest::rstest]
     #[case(NEXT_CLIENT_SEQUENCE, Path::NextClientSequence(NextClientSequencePath))]
     #[case(
@@ -1182,27 +1182,27 @@ mod tests {
     )]
     #[case(
         "clients/07-tendermint-0/clientState",
-        Path::ClientState(ClientStatePath(DUMMY_CLIENT_ID.into())))]
+        Path::ClientState(ClientStatePath(DEFAULT_CLIENT_ID.into())))]
     #[case(
         "clients/07-tendermint-0/consensusStates/15-31",
         Path::ClientConsensusState(ClientConsensusStatePath {
-            client_id: DUMMY_CLIENT_ID.into(),
+            client_id: DEFAULT_CLIENT_ID.into(),
             revision_number: 15,
             revision_height: 31,
         })
     )]
     #[case(
         "clients/07-tendermint-0/consensusStates/15-31/processedTime",
         Path::ClientUpdateTime(ClientUpdateTimePath {
-            client_id: DUMMY_CLIENT_ID.into(),
+            client_id: DEFAULT_CLIENT_ID.into(),
             revision_number: 15,
             revision_height: 31,
         })
     )]
     #[case(
         "clients/07-tendermint-0/consensusStates/15-31/processedHeight",
         Path::ClientUpdateHeight(ClientUpdateHeightPath {
-            client_id: DUMMY_CLIENT_ID.into(),
+            client_id: DEFAULT_CLIENT_ID.into(),
             revision_number: 15,
             revision_height: 31,
         })
@@ -1288,7 +1288,7 @@ mod tests {
         assert_eq!(
             parse_client_paths(&components),
             Some(Path::ClientState(ClientStatePath(ClientId::from(
-                DUMMY_CLIENT_ID
+                DEFAULT_CLIENT_ID
             ))))
         );
 
@@ -1298,7 +1298,7 @@ mod tests {
         assert_eq!(
             parse_client_paths(&components),
             Some(Path::ClientConsensusState(ClientConsensusStatePath {
-                client_id: DUMMY_CLIENT_ID.into(),
+                client_id: DEFAULT_CLIENT_ID.into(),
                 revision_number: 15,
                 revision_height: 31,
             }))
@@ -1313,7 +1313,7 @@ mod tests {
         assert_eq!(
             parse_client_paths(&components),
             Some(Path::ClientUpdateTime(ClientUpdateTimePath {
-                client_id: DUMMY_CLIENT_ID.into(),
+                client_id: DEFAULT_CLIENT_ID.into(),
                 revision_number: 15,
                 revision_height: 31,
             }))
@@ -1325,7 +1325,7 @@ mod tests {
         assert_eq!(
             parse_client_paths(&components),
             Some(Path::ClientUpdateHeight(ClientUpdateHeightPath {
-                client_id: DUMMY_CLIENT_ID.into(),
+                client_id: DEFAULT_CLIENT_ID.into(),
                 revision_number: 15,
                 revision_height: 31,
             }))