Firefox restart Brave loses permission

[Anteus]

On Firefox when restarting the browser the permission for Brave doesn't work. It's still toggled in settings but only a retoggle of the permission or a disable and enable of the extension makes it work again until the next restart. Have checked and the extension is not injected into the Brave search page after a restart of Firefox. Tried with all other addons disabled and reset privacy settings.

[infokiller]

Thanks for the report, are you able to reproduce this in Chrome?

[Anteus]

Thanks for the report, are you able to reproduce this in Chrome?

No it works fine in Chrome/Edge.

[infokiller]

OK great, I was able to reproduce this. Hope to fix it soon

[Anteus]

Got it working in Firefox. Will propose the fix upstream too.
https://github.com/fregante/webext-content-scripts/blob/73094bd60792f8fcce5515d6fbfef6725d6f4132/index.ts#L129

[Anteus]

Got it working in Firefox. Will propose the fix upstream too. https://github.com/fregante/webext-content-scripts/blob/73094bd60792f8fcce5515d6fbfef6725d6f4132/index.ts#129

It worked while running the debugger from VSCode with a Firefox profile but not when loaded manually.

Edit: any clue what it could be?

It also picks up the permission and runs while running the debugger about:debugging#/runtime/this-firefox. Just have to press the refresh button in there first.

[infokiller]

No idea, possible a Firefox bug?
Maybe worth checking on older Firefox versions

[infokiller]

Turns out I'm not even able to see the content script in the debugger, even from a new Firefox profile

[Anteus]

Turns out I'm not even able to see the content script in the debugger, even from a new Firefox profile

I got it working by removing background persistent=false it's in the updated pull request. If you open the debugger about:debugging#/runtime/this-firefox you can see that the script is not running after a restart. You can trigger it to run by enable/disable the extension, or in the debug menu chose inspect and then hit the update button. But I think it will be stopped in a few minutes again.

[infokiller]

For me, removing persistent=false doesn't change anything. Debugging the extension does work with web-ext, so maybe the issue is specific to my firefox config/state.

[Anteus]

Forgot to add that I've only tried on Firefox Dev as temporary addons get removed on restart.

[Anteus]

Event pages doesn't seem to be supported yet.
https://github.com/fregante/webext-dynamic-content-scripts#usage
fregante/webext-dynamic-content-scripts#40
Maybe could try
fregante/webext-dynamic-content-scripts@e6085ec

[fregante]

Has this been fixed? In recent Firefox versions, webext-dynamic-content-scripts uses the new chrome.scripting.registerContentScript API, which should work in event pages as well.