Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make enough components public to allow extensions from connector for custom queries #117

Open
dreamlibrarian opened this issue Feb 19, 2021 · 0 comments

Comments

@dreamlibrarian
Copy link

It should be easy to leverage the Connector components to make custom queries; as a for-instance, there's not currently a mechanism in the package for making paginated queries.

Unfortunately, in order to create a GetObjectPaginated function, one would need makeRequest and QueryParams to be fully public, or in the latter case have a method to generate a QueryParams struct from a public method.

https://github.com/infobloxopen/infoblox-go-client/blob/master/connector.go#L252 being private means I'd have to generate my own version that calls all the public methods it does, which is not ideal.

forceProxy bool
QueryParams.forceProxy being private stymies me creating my own makeRequest; I can create a QueryParams object but it's unable to be set to anything but false. By extension this makes BuildRequest less accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants