Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputs.nvidia-smi: Add config option to test a single run of nvidia-smi on plugin startup #15915

Open
LandonTClipp opened this issue Sep 19, 2024 · 1 comment · Fixed by #15916 · May be fixed by #16333
Open

inputs.nvidia-smi: Add config option to test a single run of nvidia-smi on plugin startup #15915

LandonTClipp opened this issue Sep 19, 2024 · 1 comment · Fixed by #15916 · May be fixed by #16333
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@LandonTClipp
Copy link
Contributor

Use Case

There are some cases where the nvidia-smi plugin might be found in PATH and executable, but upon running it might always return a non-zero exit code. For various reasons, in the environment I work in, this might be expected. It's thus disruptive for system logs to be polluted with infinite error messages. It's preferable in this situation to check if nvidia-smi returns a good result on plugin startup, and if not, allow the error to be bubbled up and handled according to startup_error_behavior.

Expected behavior

If test_on_startup = true and nvidia-smi returns non-zero exit code, an error should be returned from the NvidiaSMI.Start method.

Actual behavior

Config option does not exist, thus the proposal.

Additional info

No response

@srebhan
Copy link
Member

srebhan commented Dec 20, 2024

Reopening as the PR was reverted.

@srebhan srebhan reopened this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
2 participants