Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.195.2 failed to build against rust 1.83.0 #5515

Open
chenrui333 opened this issue Nov 30, 2024 · 1 comment · May be fixed by #5516
Open

0.195.2 failed to build against rust 1.83.0 #5515

chenrui333 opened this issue Nov 30, 2024 · 1 comment · May be fixed by #5516

Comments

@chenrui333
Copy link

While upgrading rust to 1.83.0, we found some regression build failure as:

     Compiling flux-core v0.154.0 (/private/tmp/flux-20241128-36971-boya0m/libflux/flux-core)
  error: elided lifetime has a name
     --> flux-core/src/ast/walk/mod.rs:183:47
      |
  181 | impl<'a> Node<'a> {
      |      -- lifetime `'a` declared here
  182 |     #[allow(missing_docs)]
  183 |     pub fn from_expr(expr: &'a Expression) -> Node {
      |                                               ^^^^ this elided lifetime gets resolved as `'a`
      |
  note: the lint level is defined here
     --> flux-core/src/lib.rs:1:38
      |
  1   | #![cfg_attr(feature = "strict", deny(warnings, missing_docs))]
      |                                      ^^^^^^^^
      = note: `#[deny(elided_named_lifetimes)]` implied by `#[deny(warnings)]`
  
  error: elided lifetime has a name
    --> flux-core/src/parser/mod.rs:44:37
     |
  42 | impl<'input> Parser<'input> {
     |      ------ lifetime `'input` declared here
  43 |     /// Instantiates a new parser with the given string as input.
  44 |     pub fn new(src: &'input str) -> Parser {
     |                                     ^^^^^^ this elided lifetime gets resolved as `'input`
  
  error: could not compile `flux-core` (lib) due to 2 previous errors

relates to:

@sersorrel
Copy link

failing the build on warnings introduces quite some packaging pain for distros on rust releases like this one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants