Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and test unique-columns feature inside sql-connector #79

Open
ozgrakkurt opened this issue Jul 15, 2023 · 1 comment
Open
Assignees

Comments

@ozgrakkurt
Copy link
Contributor

Currently it is implemented only on json-sql and it concatenates them into a string. This isn't ideal since it isn't tested and it isn't documented and implemented inside sql-connector.

Ideally we want to implement/test/document it inside sql-connector and use this api from json-sql.

current hacky implementation

@TheSamsa
Copy link

I was wondering why it was suddenly a &str thanks for the code.
Also would suggest removing this conversion in the smart module, and move it to the sql-connector itself. Probably put it into the insert.rs or upsert.rs modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants