New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build::configure() should not put node-vX.Y.Z.lib in %LocalAppData%\Temp #107

Open

mika-fischer opened this issue Dec 9, 2020 · 1 comment

Labels

mika-fischer commented Dec 9, 2020

First of all this has the potential to break CI builds in surprising ways (if temp dir is cleaned before each build)
It leads to the linker flag "/LIBPATH:C:\Users\\AppData\Local\Temp\" which has all kinds of interesting security implications
It might clash with other projects using the temp dir
Other projects (napi_rs, for instance) use OUT_DIR to store the lib

I can do a pull request if you want.

sehz added the tech debt label

Collaborator

sehz commented Dec 9, 2020

I agree, pull request will be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment