Skip to content

Commit eed7097

Browse files
authored
chore(.circleci/config.yml): electronuserland/builder:20-wine-07.24 (#1540)
## Please verify the following: - [x] `yarn build-and-test:local` passes ## Describe your PR [This job passed with the same docker image tag](https://app.circleci.com/pipelines/github/infinitered/reactotron/2519/workflows/437dbf3c-a838-49b1-b7a9-59e7df52137d/jobs/3423) a few months ago. It appears the [electron-builder](https://www.electron.build/multi-platform-build.html#provided-docker-images) docs encourage pinning specific versions for this situation, because it appears the [image tag has changed in the latest run that failed](https://app.circleci.com/pipelines/github/infinitered/reactotron/2558/workflows/5c710dfe-c28b-47f9-b693-f5c59a6327c0/jobs/3499). This PR attempt to address this by [pinning the docker image tag to a timestamped one](https://hubgw.docker.com/layers/electronuserland/builder/20-wine-07.24/images/sha256-d33a2fd3b3a86c773fec534df9cf215038180779303c6019a2964650e27e58d7) that will never change. I confirmed that this is a CI issue by trying to do the build on my local windows machine and it passed.
1 parent 8ec0e10 commit eed7097

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

.circleci/config.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ parameters:
1212
# Anchors define reusable sections of YAML
1313
# See: https://support.atlassian.com/bitbucket-cloud/docs/yaml-anchors/
1414
anchors:
15-
1615
### Executors
1716
node_executor: &node_executor
1817
name: node/default
@@ -45,7 +44,6 @@ anchors:
4544
target_repo: [email protected]:infinitered/ir-docs.git
4645
target_repo_directory: ir-docs
4746

48-
4947
orbs:
5048
node: circleci/[email protected]
5149
publish-docs: infinitered/[email protected]
@@ -283,7 +281,7 @@ jobs:
283281
executor: *node_executor
284282
<<: *defaults
285283
docker:
286-
- image: electronuserland/builder:20-wine
284+
- image: electronuserland/builder:20-wine-07.24
287285
resource_class: large
288286
environment:
289287
BUILD_TARGET: windows
@@ -355,7 +353,7 @@ workflows:
355353
when:
356354
and:
357355
- not: << pipeline.parameters.force-publish-docs >>
358-
- true # Placeholder for correct YAML structure
356+
- true # Placeholder for correct YAML structure
359357
jobs:
360358
- trust_check:
361359
filters:
@@ -387,7 +385,7 @@ workflows:
387385
when:
388386
and:
389387
- not: << pipeline.parameters.force-publish-docs >>
390-
- true # Placeholder for correct YAML structure
388+
- true # Placeholder for correct YAML structure
391389
jobs:
392390
- build_and_test:
393391
filters:

apps/reactotron-app/src/renderer/App.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ const AppContainer = styled.div`
2222
bottom: 0;
2323
left: 0;
2424
right: 0;
25-
2625
display: flex;
2726
flex-direction: column;
2827
background-color: ${(props) => props.theme.background};

0 commit comments

Comments
 (0)