Skip to content

Commit e5dbe31

Browse files
authored
chore: adjust bucket size of overview metric (#9)
1 parent eedcda0 commit e5dbe31

File tree

3 files changed

+16
-27
lines changed

3 files changed

+16
-27
lines changed

modules/elastic/api/cluster_overview.go

+5-14
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,10 @@ func (h *APIHandler) FetchClusterInfo(w http.ResponseWriter, req *http.Request,
133133
var top = len(clusterIDs) + 1
134134

135135
bucketSize := GetMinBucketSize()
136-
if bucketSize < 20 {
137-
bucketSize = 20
136+
if bucketSize < 60 {
137+
bucketSize = 60
138138
}
139139
var metricLen = 15
140-
if bucketSize <= 60 {
141-
metricLen += 2
142-
}
143140
var bucketSizeStr = fmt.Sprintf("%vs", bucketSize)
144141
indexMetricItems := []GroupMetricItem{}
145142
metricItem := newMetricItem("cluster_indexing", 2, "cluster")
@@ -260,7 +257,7 @@ func (h *APIHandler) FetchClusterInfo(w http.ResponseWriter, req *http.Request,
260257
for _, line := range indexMetrics["cluster_indexing"].Lines {
261258
// remove first metric dot
262259
data := line.Data
263-
if v, ok := data.([][]interface{}); ok && len(v)> 0 && bucketSize <= 60 {
260+
if v, ok := data.([][]interface{}); ok && len(v)> 0 {
264261
// remove first metric dot
265262
temp := v[1:]
266263
// // remove first last dot
@@ -274,7 +271,7 @@ func (h *APIHandler) FetchClusterInfo(w http.ResponseWriter, req *http.Request,
274271
searchMetricData := util.MapStr{}
275272
for _, line := range indexMetrics["cluster_search"].Lines {
276273
data := line.Data
277-
if v, ok := data.([][]interface{}); ok && len(v)> 0 && bucketSize <= 60 {
274+
if v, ok := data.([][]interface{}); ok && len(v)> 0 {
278275
// remove first metric dot
279276
temp := v[1:]
280277
// // remove first last dot
@@ -286,12 +283,6 @@ func (h *APIHandler) FetchClusterInfo(w http.ResponseWriter, req *http.Request,
286283
searchMetricData[line.Metric.Label] = data
287284
}
288285

289-
searchR1, err := elastic.GetClient(clusterID).SearchWithRawQueryDSL(getAllMetricsIndex(), util.MustToJSONBytes(query))
290-
if err != nil {
291-
panic(err)
292-
}
293-
294-
295286
//fetch recent cluster health status
296287
bucketItem := common.NewBucketItem(
297288
common.TermsBucket, util.MapStr{
@@ -409,7 +400,7 @@ func (h *APIHandler) FetchClusterInfo(w http.ResponseWriter, req *http.Request,
409400

410401
util.MergeFields(query, aggs, true)
411402

412-
searchR1, err = elastic.GetClient(global.MustLookupString(elastic.GlobalSystemElasticsearchID)).SearchWithRawQueryDSL(getAllMetricsIndex(), util.MustToJSONBytes(query))
403+
searchR1, err := elastic.GetClient(global.MustLookupString(elastic.GlobalSystemElasticsearchID)).SearchWithRawQueryDSL(getAllMetricsIndex(), util.MustToJSONBytes(query))
413404
if err != nil {
414405
panic(err)
415406
}

modules/elastic/api/index_overview.go

+5-6
Original file line numberDiff line numberDiff line change
@@ -365,11 +365,11 @@ func (h *APIHandler) FetchIndexInfo(w http.ResponseWriter, req *http.Request, p
365365
return
366366
}
367367

368-
bucketSize, min, max, err := h.getMetricRangeAndBucketSize(req, 60, (15))
369-
if err != nil {
370-
panic(err)
371-
return
368+
bucketSize := GetMinBucketSize()
369+
if bucketSize < 60 {
370+
bucketSize = 60
372371
}
372+
var metricLen = 15
373373
// 索引速率
374374
indexMetric:=newMetricItem("indexing", 1, OperationGroupKey)
375375
indexMetric.OnlyPrimary = true
@@ -425,8 +425,7 @@ func (h *APIHandler) FetchIndexInfo(w http.ResponseWriter, req *http.Request, p
425425
{
426426
"range": util.MapStr{
427427
"timestamp": util.MapStr{
428-
"gte": min,
429-
"lte": max,
428+
"gte": fmt.Sprintf("now-%ds", metricLen * bucketSize),
430429
},
431430
},
432431
},

modules/elastic/api/node_overview.go

+6-7
Original file line numberDiff line numberDiff line change
@@ -305,11 +305,6 @@ func (h *APIHandler) FetchNodeInfo(w http.ResponseWriter, req *http.Request, ps
305305
h.WriteError(w, err.Error(), http.StatusInternalServerError)
306306
return
307307
}
308-
bucketSize, min, max, err := h.getMetricRangeAndBucketSize(req, 60, (15))
309-
if err != nil {
310-
panic(err)
311-
return
312-
}
313308
// 索引速率
314309
indexMetric:=newMetricItem("indexing", 1, OperationGroupKey)
315310
indexMetric.AddAxi("indexing rate","group1",common.PositionLeft,"num","0,0","0,0.[00]",5,true)
@@ -335,6 +330,11 @@ func (h *APIHandler) FetchNodeInfo(w http.ResponseWriter, req *http.Request, ps
335330
Units: "Search/s",
336331
})
337332

333+
bucketSize := GetMinBucketSize()
334+
if bucketSize < 60 {
335+
bucketSize = 60
336+
}
337+
var metricLen = 15
338338
aggs:=map[string]interface{}{}
339339
query=map[string]interface{}{}
340340
query["query"]=util.MapStr{
@@ -364,8 +364,7 @@ func (h *APIHandler) FetchNodeInfo(w http.ResponseWriter, req *http.Request, ps
364364
{
365365
"range": util.MapStr{
366366
"timestamp": util.MapStr{
367-
"gte": min,
368-
"lte": max,
367+
"gte": fmt.Sprintf("now-%ds", metricLen * bucketSize),
369368
},
370369
},
371370
},

0 commit comments

Comments
 (0)