Skip to content

Commit 9f177b2

Browse files
author
yaojiping
committed
fix: permission verification of some menu is invalid
1 parent b17b963 commit 9f177b2

File tree

10 files changed

+30
-29
lines changed

10 files changed

+30
-29
lines changed

web/config/router.config.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ export default [
162162
name: "alerting",
163163
icon: "alert",
164164
authority: ["alerting"],
165-
isPro: true,
166165
routes: [
167166
{
168167
path: "/alerting/message/:message_id",
@@ -386,12 +385,17 @@ export default [
386385
"system.credential:read",
387386
"system.security:all",
388387
"system.security:read",
388+
"system.audit_logs:all",
389+
"system.audit_logs:read",
390+
"system.smtp_server:all",
391+
"system.smtp_server:read"
389392
],
390393
routes: [
391394
{
392395
path: "/system/email_server",
393-
name: "email_server",
396+
name: "smtp_server",
394397
component: "./System/Email/Server",
398+
authority: ["system.smtp_server:all", "system.smtp_server:read"],
395399
},
396400
{
397401
path: "/system/credential",

web/src/components/SiderMenu/BaseMenu.js

-10
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { formatMessage } from 'umi/locale';
77
import pathToRegexp from 'path-to-regexp';
88
import { urlToList } from '../_utils/pathTools';
99
import styles from './index.less';
10-
import Pro from '../Icons/Pro';
1110

1211
const { SubMenu } = Menu;
1312

@@ -89,7 +88,6 @@ export default class BaseMenu extends PureComponent {
8988
<span style={{ display: 'flex', alignItems: 'center'}}>
9089
{getIcon(item.icon)}
9190
<span style={{ overflow: 'hidden', textOverflow: 'ellipsis'}}>{name}</span>
92-
{this.renderProIcon(item)}
9391
</span>
9492
) : (
9593
name
@@ -140,7 +138,6 @@ export default class BaseMenu extends PureComponent {
140138
<span style={{ display: 'flex', alignItems: 'center'}}>
141139
{icon}
142140
<span style={{ overflow: 'hidden', textOverflow: 'ellipsis'}}>{name}</span>
143-
{this.renderProIcon(item)}
144141
</span>
145142
</Link>
146143
);
@@ -163,13 +160,6 @@ export default class BaseMenu extends PureComponent {
163160
return `/${path || ''}`.replace(/\/+/g, '/');
164161
};
165162

166-
renderProIcon = (item) => {
167-
if (this.props.collapsed || !item.isPro) return null
168-
return (
169-
<Icon style={{ fontSize: 32, marginLeft: 6 }} component={Pro}/>
170-
)
171-
}
172-
173163
render() {
174164
const {
175165
openKeys,

web/src/locales/en-US.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ export default {
271271
"menu.system.reset_password": "RESET",
272272

273273
"menu.system.credential": "CREDENTIAL",
274-
"menu.system.email_server": "SMTP SERVER",
274+
"menu.system.smtp_server": "SMTP SERVER",
275275

276276
"menu.form": "Form",
277277
"menu.form.basicform": "Basic Form",

web/src/locales/en-US/settings.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export default {
2-
"settings.email.server.empty.label1": "You can add mail servers here",
2+
"settings.email.server.empty.label1": "You can add email servers here",
33
"settings.email.server.empty.label2":
44
"The alart center can send a notification to the recipient through the designated mail server",
5-
"settings.email.server.empty.button.new": "Add mail server",
5+
"settings.email.server.empty.button.new": "Add email server",
66
};

web/src/locales/zh-CN.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ export default {
276276
"menu.system.reset_password": "重置密码",
277277

278278
"menu.system.credential": "凭据管理",
279-
"menu.system.email_server": "邮件服务器",
279+
"menu.system.smtp_server": "邮件服务器",
280280

281281
"menu.form": "表单页",
282282
"menu.form.basicform": "基础表单",

web/src/pages/DataManagement/Discover.jsx

+7-3
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ import Layout from "./View/Layout";
8484
import request from "@/utils/request";
8585
import { cloneDeep } from "lodash";
8686
import { getTimezone } from "@/utils/utils";
87+
import { hasAuthority } from "@/utils/authority";
8788

8889
const SidebarMemoized = React.memo(DiscoverSidebar);
8990

@@ -1553,10 +1554,13 @@ const DiscoverUI = (props) => {
15531554
The current cluster has no indices or views
15541555
</span>
15551556
}
1557+
image={Empty.PRESENTED_IMAGE_SIMPLE}
15561558
>
1557-
<Link to={"/data/index"}>
1558-
<Button type="primary">Create Now</Button>
1559-
</Link>
1559+
{hasAuthority("data.index:all") && (
1560+
<Link to={"/data/index"}>
1561+
<Button type="primary">Create Now</Button>
1562+
</Link>
1563+
)}
15601564
</Empty>
15611565
</Card>
15621566
)

web/src/pages/DataManagement/IndexPatterns.jsx

+2-4
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,11 @@ import { ESPrefix } from "@/services/common";
1818
import { formatMessage } from "umi/locale";
1919
import { getAuthority, hasAuthority } from "@/utils/authority";
2020
import EditLayout from "./View/EditLayout";
21+
import { Card, Empty } from "antd";
2122

2223
const IndexPatterns = (props) => {
2324
if (!props.selectedCluster?.id) {
24-
return null;
25+
return <Card ><Empty image={Empty.PRESENTED_IMAGE_SIMPLE} /></Card>;
2526
}
2627
const history = useMemo(() => {
2728
return new ScopedHistory(props.history, "/data/views");
@@ -45,9 +46,6 @@ const IndexPatterns = (props) => {
4546
};
4647
initFetch();
4748
}, [props.selectedCluster]);
48-
if (!props.selectedCluster?.id) {
49-
return null;
50-
}
5149

5250
return (
5351
<Router history={history}>

web/src/pages/Platform/Overview/Indices/index.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ import Table from "./Table";
66
import Overview from "@/components/Overview";
77

88
const facetLabels = {
9-
"metadata.cluster_name": "cluster",
9+
"metadata.index_name": "index",
1010
"metadata.labels.health_status": "health",
1111
"metadata.labels.state": "state",
1212
};
1313

1414
const aggsParams = [
15-
{ field: "metadata.cluster_name", params: { size: 500 } },
15+
{ field: "metadata.index_name", params: { size: 500 } },
1616
{ field: "metadata.labels.state", params: { size: 100 } },
1717
{ field: "metadata.labels.health_status", params: { size: 150 } },
1818
];

web/src/pages/System/Email/Components/EmptyServer.jsx

+8-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { Empty, Button } from "antd";
22
import EmailServer from "@/components/Icons/EmailServer";
33
import { formatMessage } from "umi/locale";
4+
import { hasAuthority } from "@/utils/authority";
45

56
export default ({ onAddClick }) => {
67
const onClick = () => {
@@ -23,9 +24,13 @@ export default ({ onAddClick }) => {
2324
</div>
2425
}
2526
>
26-
<Button type="primary" onClick={onClick}>
27-
{formatMessage({ id: "settings.email.server.empty.button.new" })}
28-
</Button>
27+
{
28+
hasAuthority("system.smtp_server:all") && (
29+
<Button type="primary" onClick={onClick}>
30+
{formatMessage({ id: "settings.email.server.empty.button.new" })}
31+
</Button>
32+
)
33+
}
2934
</Empty>
3035
);
3136
};

web/src/pages/System/Role/Platform/menu.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export const menuData = [
9696
key: "system",
9797
children: [
9898
{
99-
key: "system.email_server",
99+
key: "system.smtp_server",
100100
},
101101
{
102102
key: "system.security",

0 commit comments

Comments
 (0)