Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider sorting other types of enums? #72

Open
zachbryant opened this issue Dec 10, 2023 · 2 comments
Open

Consider sorting other types of enums? #72

zachbryant opened this issue Dec 10, 2023 · 2 comments

Comments

@zachbryant
Copy link

zachbryant commented Dec 10, 2023

I'm finalizing my branch before PR for #26 and I noticed the linter works just fine on other kinds of enums. For example, the test case enum U {c=1<<1, b, a} has no special work required to sort. Is there a specific reason to only sort string enums? If not, I'd propose changing the rule to just enum instead of string-enum.

I figured something such as changing rule names should be part of a major version change, might as well lump it in with the same PR

@infctr
Copy link
Owner

infctr commented Dec 10, 2023

Hey, @zachbryant
Thank you for your time and effort working on the issue!
Let's add a new rule for that matter to make it backwards compatible, WDYT?

@zachbryant
Copy link
Author

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants