From cd73c2ca73a53c3082653c6ec4ba3fd3b2542496 Mon Sep 17 00:00:00 2001 From: Johannes Schneider Date: Tue, 11 Apr 2023 22:05:47 +0200 Subject: [PATCH] [collision-query] Fix clang-tidy warning --- src/vulkan-renderer/world/collision_query.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vulkan-renderer/world/collision_query.cpp b/src/vulkan-renderer/world/collision_query.cpp index 977bd6907..0194d3371 100644 --- a/src/vulkan-renderer/world/collision_query.cpp +++ b/src/vulkan-renderer/world/collision_query.cpp @@ -32,7 +32,7 @@ bool ray_box_collision(const std::array &box_bounds, const glm::ve float tzmin{(box_bounds[sign[2]].z - position.z) * inverse_dir.z}; float tzmax{(box_bounds[1 - sign[2]].z - position.z) * inverse_dir.z}; - return !((tmin > tzmax) || (tzmin > tmax)); + return ((tmin <= tzmax) && (tzmin <= tmax)); } std::optional> ray_cube_collision_check(const Cube &cube, const glm::vec3 pos,