Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional pages don't contribute to the point count #621

Open
inducer opened this issue Oct 2, 2018 · 3 comments
Open

Optional pages don't contribute to the point count #621

inducer opened this issue Oct 2, 2018 · 3 comments

Comments

@inducer
Copy link
Owner

inducer commented Oct 2, 2018

@dzhuang When you introduced is_optional_page: True, you made it so that optional pages do not contribute to the point count. I'm not sure I understand the logic behind that. Could you explain?
@inducer inducer mentioned this issue Oct 2, 2018
Open
@dzhuang
Copy link
Contributor

dzhuang commented Oct 7, 2018

Sorry, I'm just back from a vacation. I'll look into this asap.

@dzhuang
Copy link
Contributor

dzhuang commented Oct 28, 2018

I think we've discussed that here. Based on that, points will be ignored as of here and there'll be warning when validating as of here if both is_optional_page and value present.

@inducer
Copy link
Owner Author

inducer commented Oct 31, 2018

Hum. I kind of no longer agree with the logic. See discussion in #623.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inducer @dzhuang