Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime picker issue #362

Closed
dzhuang opened this issue Sep 15, 2017 · 7 comments
Closed

Datetime picker issue #362

dzhuang opened this issue Sep 15, 2017 · 7 comments

Comments

@dzhuang
Copy link
Contributor

dzhuang commented Sep 15, 2017

For form with multiple datetime picker widget (new course page and edit course page), only first picker worked. I'm using Django 1.10.7, not sure if Django1.11 worked @inducer .

I report it here because the source repo is not maintained and we are using the patched fork. I'm quite sure the reason is my patch.

We might have to test this one: jsanchezislas/django-bootstrap3-datetimepicker@e147ebe

@dzhuang
Copy link
Contributor Author

dzhuang commented Sep 15, 2017

A temp workround: here

@inducer
Copy link
Owner

inducer commented Sep 15, 2017

I'm open to switching to the jsanchezislas one. Could you test it and submit a PR?

@dzhuang
Copy link
Contributor Author

dzhuang commented Sep 19, 2017

Ok. But I don't have time to test that right now. Perhaps this weekend.

@dzhuang
Copy link
Contributor Author

dzhuang commented Sep 19, 2017

One question, which version of Django your are using right now? If it's 1.11.x, can all widgets in setup new course page and edit course page working correctly? @inducer

@dzhuang
Copy link
Contributor Author

dzhuang commented Sep 24, 2017

My tests failed. One of the issue was metioned by https://gitlab.tiker.net/inducer/relate/merge_requests/42

I discovered that the issue is caused by the removal of the size() function in the recent update of jquery.

and nkunihiko/django-bootstrap3-datetimepicker#58

@dzhuang
Copy link
Contributor Author

dzhuang commented Sep 25, 2017

@inducer
Copy link
Owner

inducer commented Sep 26, 2017

Merged above PR, verified fix. Thank you!

@inducer inducer closed this as completed Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants