Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks bad on iPhone #6

Open
jernst opened this issue Jul 1, 2017 · 22 comments
Open

Looks bad on iPhone #6

jernst opened this issue Jul 1, 2017 · 22 comments
Assignees

Comments

@jernst
Copy link
Member

jernst commented Jul 1, 2017

@indietechrocks/all : indietech.rocks looks not so great on iPhone. Don't know about Android.

I know nothing about how to get the CSS right on mobile, does anybody here have a few cycles editing CSS?

@jackjamieson2
Copy link
Member

Hi Johannes, I could take a look at this next week if you like.

@jernst
Copy link
Member Author

jernst commented Jul 1, 2017 via email

@jackjamieson2 jackjamieson2 self-assigned this Jul 2, 2017
@jackjamieson2
Copy link
Member

Hi Johannes, how do you feel about reformatting the table on small screens as per: https://css-tricks.com/responsive-data-tables/

A little messy but I think it'd get the job done.

@jernst
Copy link
Member Author

jernst commented Jul 3, 2017

I have no opinion. Try it out?

@jackjamieson2
Copy link
Member

I've edited _indietechrocks.scss to reformat the tables, but I'm not sure how to get media queries working with sass. Do you have any idea?

@jernst
Copy link
Member Author

jernst commented Jul 3, 2017

I haven't done this, but I would assume that you can write it like plain CSS. Hierarchy and $vars optional ..

@jackjamieson2
Copy link
Member

Got it — turned out I had a couple typos elsewhere. Take a look on mobile if you like - A bit easier to read on my android phone than it was before

@jernst
Copy link
Member Author

jernst commented Jul 3, 2017

Excellent! Looks much better. Does the animated logo come up on Android? It doesn't on iPhone. Is there a way of using a static PNG instead of the SVG on mobile?

@kartikprabhu
Copy link
Contributor

kartikprabhu commented Jul 3, 2017 via email

@jackjamieson2
Copy link
Member

The animated logo displays correctly on my Android in Firefox and Chrome.

@jernst
Copy link
Member Author

jernst commented Jul 3, 2017

Darn iPhones! Actually, it does not work in my version of OSX Safari either. Any idea how to switch to something else "on Apple devices only"?

@kartikprabhu
Copy link
Contributor

kartikprabhu commented Jul 3, 2017 via email

@jernst
Copy link
Member Author

jernst commented Jul 4, 2017

This did not work. See http://indietech.rocks/ -- I don't understand where it gets its coordinates from. And there's still nothing on the iPhone.

@kartikprabhu
Copy link
Contributor

kartikprabhu commented Jul 4, 2017 via email

@jernst
Copy link
Member Author

jernst commented Jul 5, 2017

I played around with it some more after the 4th-of-July BBQ :-) and got somewhere. Not optimal, but a PNG replacement now shows up on iPhone and Safari: basically, I put the PNG fallback as a background image in the div inclosing the SVG, and the SVG first paints a big box with the background color, thereby painting over the SVG.

I could not get the picture element formatted, it placed its insides all over the map, just not where I wanted them to be.

@kartikprabhu kartikprabhu mentioned this issue Jul 6, 2017
@jernst
Copy link
Member Author

jernst commented Jul 7, 2017

@kartikprabhu Thanks for your pull request, which I merged, but it does not seem to work for me. The logo has again disappeared on Safari/OSX and iPhone. See currently deployed site.

@kartikprabhu
Copy link
Contributor

@jernst that is very strange. I don't have a good way of testing on Safari or iPhone. Maybe Safari is just ignoring SVG for some strange reason.

@kartikprabhu
Copy link
Contributor

btw the site looks nice on Android. FF and Chrome show the animated SVG while Opera shows the static logo

@jernst
Copy link
Member Author

jernst commented Jul 8, 2017

@jernst
Copy link
Member Author

jernst commented Jul 8, 2017

Does not seem like it. Also, if I go to http://indietech.rocks/images/logo.svg directly, Safari does not display it either. Works in FF and Chrome.

@jernst
Copy link
Member Author

jernst commented Jul 10, 2017

So I reverted back to the PNG background image, I guess that's the best we can do.

@jernst jernst closed this as completed Jul 10, 2017
@jernst
Copy link
Member Author

jernst commented Jul 16, 2017

We are doing something wrong here. Just noticed that https://kodi.tv uses a SVG image as their main logo, and it works fine on Safari (Mac and iPad, not tried on iPhone)

@jernst jernst reopened this Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants