-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize test framework #282
Comments
after spending some time with the test I think it's definitively a must have. For frameworks I had in mind ava, jest, and mocha. I would rather tend to jest because it has a describe/it nested test structure that ava does not have. |
@mhamann Shall I start to translate some of the test (some in ava, some in jest to serve as base of comparison?) |
Yep, go for it. If Jest feels like a good fit, I am fine moving forward with that. I have no real attachment to either. |
I started working on jest migration, you can see the first result there: Waiting for your go @mhamann to go further. :) |
LGTM. |
Voilà I made the whole transition, tell me what you think @mhamann 😃 (by the way, did you add chance to advance on the 0.10? =) ) |
@mhamann up :) |
Thanks--PR looking good. Hoping to finish reviewing by end of week. I'll also get 0.10 then as well. Sorry for the delay--life has been a bit crazy the past couple of weeks. Appreciate the reminder! |
No problem, take the time you need. |
Hey @mhamann ! |
Convert existing
vows.js
based test suite to something a bit more common and well-known. This will help newer contributors understand how to write an effective test, which will lower the barrier to entry.Potential frameworks include: ava, tap, and mocha.
The text was updated successfully, but these errors were encountered: