Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize test framework #282

Open
mhamann opened this issue Oct 29, 2017 · 10 comments
Open

Modernize test framework #282

mhamann opened this issue Oct 29, 2017 · 10 comments
Milestone

Comments

@mhamann
Copy link
Collaborator

mhamann commented Oct 29, 2017

Convert existing vows.js based test suite to something a bit more common and well-known. This will help newer contributors understand how to write an effective test, which will lower the barrier to entry.

Potential frameworks include: ava, tap, and mocha.

@mhamann mhamann added this to the v1.0.0 milestone Oct 30, 2017
@AdrieanKhisbe
Copy link
Contributor

after spending some time with the test I think it's definitively a must have.
Besides vows is unmaintained for years.

For frameworks I had in mind ava, jest, and mocha.
The two first are the most trending theses days, and probably more jest than ava with react traction.

I would rather tend to jest because it has a describe/it nested test structure that ava does not have.

(https://stackshare.io/stackups/jest-vs-ava)

@AdrieanKhisbe
Copy link
Contributor

@mhamann Shall I start to translate some of the test (some in ava, some in jest to serve as base of comparison?)

@mhamann
Copy link
Collaborator Author

mhamann commented Nov 8, 2017

Yep, go for it. If Jest feels like a good fit, I am fine moving forward with that. I have no real attachment to either.

@AdrieanKhisbe
Copy link
Contributor

AdrieanKhisbe commented Nov 11, 2017

I started working on jest migration, you can see the first result there:
https://github.com/indexzero/nconf/compare/master...AdrieanKhisbe:migrating-test-to-jest?expand=1

Waiting for your go @mhamann to go further. :)

@mhamann
Copy link
Collaborator Author

mhamann commented Nov 11, 2017

LGTM.

@AdrieanKhisbe
Copy link
Contributor

Voilà I made the whole transition, tell me what you think @mhamann 😃

(by the way, did you add chance to advance on the 0.10? =) )

@AdrieanKhisbe
Copy link
Contributor

@mhamann up :)

@mhamann
Copy link
Collaborator Author

mhamann commented Nov 16, 2017

Thanks--PR looking good. Hoping to finish reviewing by end of week. I'll also get 0.10 then as well. Sorry for the delay--life has been a bit crazy the past couple of weeks. Appreciate the reminder!

@AdrieanKhisbe
Copy link
Contributor

No problem, take the time you need.
and courage!! :)

@AdrieanKhisbe
Copy link
Contributor

Hey @mhamann !
I hope the crazy times are fading away.
Tell me if you need help on thé nconf part =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants