Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE to be less confusing #526

Open
longquanzheng opened this issue Dec 18, 2024 · 0 comments
Open

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Dec 18, 2024

https://github.com/indeedeng/iwf-idl/blob/a7fb55597de5591fffa406b6b5f07d85fda4dfee/iwf.yaml#L877C11-L877C50

This is useful when the state API has eventually failed, but confusing when the state API is failing with backoff retry.

People may think it's because of retry has max out but didn't think about that it's their state API throwing errors...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant