Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using empty stateStartApiSuccess to indicate success #520

Open
longquanzheng opened this issue Dec 13, 2024 · 0 comments
Open

Using empty stateStartApiSuccess to indicate success #520

longquanzheng opened this issue Dec 13, 2024 · 0 comments

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Dec 13, 2024

commandRes.StateStartApiSucceeded = iwfidl.PtrBool(errStartApi == nil)

99.99% of the time, the value is true and we have to pass "stateStartApiSuccess":true to worker. We could make the field default as true so that we don't have to send this value.

However, a bool field default to true may be a bit confusing, so we could rename it to stateWaitUntilFailed in the IDL.
SDK can be adapted to the value

@longquanzheng longquanzheng changed the title Replace stateStartApiSuccess with stateWaitUntilFailed Using empty stateStartApiSuccess to indicate success Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant