-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Castlemouse in gallery has heaps of errors #1050
Comments
Fixed version |
Hi, thanks for the issue. These are tests based on code out in the wild that I don't want to break (that's why a lot of errors are spat out as warnings instead). I want the janky examples in the test suite - there are others, even worse! (I make some exceptions, but generally have not breaking existing games as one of the highest priorities) |
In my view janky examples in the test suite are highly desirable, but janky examples in the gallery for people to use as examples are definitely not. YMMV. |
Oh sorry, the gallery, not the tests. Right! Yes, I should fix ^^. (Maybe. Let's see...) |
See https://www.puzzlescript.net/editor.html?hack=6976592
The error is
Commands should only appear at the end of rules, not in or before the pattern-detection/-replacement sections.
The rule is:
right [ Elephant | Stationary Dog | No Obstacle ] -> [ Elephant | right Dog | SFX3 ]
It should be
right [ Elephant | Stationary Dog | No Obstacle ] -> [ Elephant | right Dog | ] SFX3
They display as warnings, but they actually are errors.
The text was updated successfully, but these errors were encountered: