Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for get_locs(): add 'filterlength_guessed' column in the return value #109

Open
florisvdh opened this issue Sep 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@florisvdh
Copy link
Member

florisvdh commented Sep 9, 2024

See:

watina/R/get.R

Lines 443 to 445 in fe50ec2

filterlength = ifelse(is.na(.data$FilterLengte),
0.3,
.data$FilterLengte),

and (PR #108):

watina/R/get.R

Lines 443 to 446 in a02cd40

filterlength = ifelse(is.na(.data$FilterLengte) |
.data$FilterLengte == 0,
0.3,
.data$FilterLengte),

Replacing missing (and in the future, also zero) filterlengths, by 0.3 m, has always been imposed by get_locs().

However this is not evident from the output, nor the documentation (not in documentation because the Value section needs to be extended; see also #47).

However in the output this should be made clear by including a filterlength_guessed variable (logical). This is similar to filterdepth_guessed; the latter appearing only if argument filterdepth_guess = TRUE.

@florisvdh florisvdh added the enhancement New feature or request label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant