Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure of sublayout verification leads to failure of entire verification routine #23

Open
adityasaky opened this issue Feb 20, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@adityasaky
Copy link
Member

adityasaky commented Feb 20, 2019

Please fill in the fields below to submit an issue or feature request. The
more information that is provided, the better.

Description of issue or feature request:

#19 introduced sublayout verification capabilities, which closely resemble the reference implementation. Currently, the overall verification process fails as soon as sublayout verification fails at some stage, instead of proceeding with other steps and checking for threshold value later.

Expected behavior:

The implementation must continue the verification routine and consider summary links only from successfully verified sublayouts. The verification routine can then check if threshold value is met further down the line.

For more details: #19 (comment)

@shibumi shibumi added bug Something isn't working good first issue Good for newcomers labels Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants