Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add co-author to the initial commit #7

Open
Bachibouzouk opened this issue May 27, 2024 · 4 comments
Open

Add co-author to the initial commit #7

Bachibouzouk opened this issue May 27, 2024 · 4 comments

Comments

@Bachibouzouk
Copy link

Hello,

Thank you for creating this repository :)

As a lot of the work stems from @SoniBhaveshh (RAMP-project/RAMP#141), I think it would be fair to rebase and edit the commit messages to explicitly mark him as a co-author. Especially now that there are not many commits since the initial one and that few people have been using this repository ( as rebase will change the commit numbers).

To add co-author within the commits:
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

@Bachibouzouk
Copy link
Author

I overlooked the PR #6 in which it seems are the changes made by @SoniBhaveshh.

Do you plan to merge them?

@SoniBhaveshh
Copy link
Contributor

hi @Bachibouzouk it seems that Mr. Andreas Lubojanski @pyrokar1993 has merged it. I guess you may now fork it to main RAMP project.

@SoniBhaveshh
Copy link
Contributor

.

@Bachibouzouk
Copy link
Author

hi @Bachibouzouk it seems that Mr. Andreas Lubojanski @pyrokar1993 has merged it. I guess you may now fork it to main RAMP project.

Thank you @SoniBhaveshh I will fork it when I find some time for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants