This repository has been archived by the owner on Jul 20, 2022. It is now read-only.

Breaking change with modal_bottom_sheet: 1.0.0-dev #118

Closed

LefebvreIlyas opened this issue Oct 27, 2020 · 0 comments · Fixed by #121

Contributor

LefebvreIlyas commented Oct 27, 2020 •

edited

Loading

Hello @imtoori,

Thanks for the package! 🎉

[1.0.0-dev] - Improved performance and breaking change

The builder param has changed from:

showMaterialModalBottomSheet(
  context: context,
  builder: (context, scrollController) {
       return SingleChildScrollView(
        controller: scrollController,
        child: Container()
      )
  },
)

to

showMaterialModalBottomSheet(
  context: context,
  builder: (context) {
      return SingleChildScrollView(
        controller: ModalScrollController.of(context),
        child: Container()
      )
  },
)

See https://github.com/jamesblasco/modal_bottom_sheet/blob/master/CHANGELOG.md#100-dev---improved-performance-and-breaking-change.

The text was updated successfully, but these errors were encountered:

LefebvreIlyas mentioned this issue

Update to modal_bottom_sheet: ^1.0.1-dev #121

Merged

imtoori closed this as completed in #121

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.