Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Helper namespace should match autoloaded directory #55

Open
kjohnson opened this issue Oct 19, 2021 · 0 comments
Open

View Helper namespace should match autoloaded directory #55

kjohnson opened this issue Oct 19, 2021 · 0 comments
Labels
type: bug Existing functionality is broken

Comments

@kjohnson
Copy link
Member

The View class, at the top level of the Addon domain, has a namsepace that does not match the autoloaded directory. Specifically, the namespace include Helpers while not being located in a /Helpers sub-folder.

see src/Addon/View.php

<?php

namespace GiveBitPay\Addon\Helpers;

class View {
    //
}

Instead the namespace should simply be GiveBitPay\Addon.

<?php

namespace GiveBitPay\Addon;

class View {
    //
}
@kjohnson kjohnson added the type: bug Existing functionality is broken label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Existing functionality is broken
Projects
None yet
Development

No branches or pull requests

1 participant