Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked photos may be rendering in duplicate with the new Kysely migration #15280

Closed
1 of 3 tasks
aminesebastian opened this issue Jan 12, 2025 · 2 comments
Closed
1 of 3 tasks

Comments

@aminesebastian
Copy link

The bug

Heyo folks!

I have a fork of Immich I've been using to add stacked photo viewing to albums while waiting for the outstanding PR for that to get merged. I'd initially forked straight from main (not from the latest release commit) and found that stacks were having the individual photos within them displayed on the timeline alongside the stack. It looks like the logic to de-dup when withStacked is passed is not working after the Kysely migration. When querying for a stacked asset that is not the primary for the stack, the stack value is the response is null.

Whatever the issue is, it appears to be with the query and not with how data is written, bc flipping between using the latest release tag and main as the base for my custom build hides and resolves the issue.

The OS that Immich Server is running on

Slackware (Unraid)

Version of Immich Server

latest main

Version of Immich Mobile App

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

-

Your .env content

-

Reproduction steps

  1. Create a photo stack - note that everything looks as it should (based on my cursory reading, it looks like the web client removes the stacked photos on the client-cached assetStore).
  2. Refresh the page -- note that the stack now appears, but so do all the photos inside it.
  3. Switch to the latest release branch and note that the stack appears, but the photos inside do not (expected behaviour).

Relevant log output

No response

Additional information

No response

@aminesebastian
Copy link
Author

cc @mertalev -- I'm thinking this PR might be where the issue started. I've only started looking at Immich code today, so please forgive me if I'm way off base here 😅.

@mertalev
Copy link
Contributor

mertalev commented Jan 23, 2025

Thanks, this was fixed in #15509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants