Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaarli icon not shown in header and footer #5

Open
bttrx opened this issue Sep 24, 2024 · 3 comments
Open

Shaarli icon not shown in header and footer #5

bttrx opened this issue Sep 24, 2024 · 3 comments

Comments

@bttrx
Copy link

bttrx commented Sep 24, 2024

Hi!

I'm using your latest toolbar and Shaarli 0.13.0. When your plugin is enabled, Shaarli's default theme doesn't show "the Shaarli star" icon, but a hieroglyph.

Header:
grafik

Footer:
grafik

Your FontAwesome is overwriting Shaarli's ForkAwesome:
grafik

@immanuelfodor
Copy link
Owner

Oh, I'm sorry to hear it. I'm using the Material theme, so I never had this issue.

Could you please try commenting out or deleting this line in your plugin to see if it fixes the issue?
https://github.com/immanuelfodor/shaarli-markdown-toolbar/blob/master/markdown_toolbar/markdown_toolbar.php#L80

@bttrx
Copy link
Author

bttrx commented Sep 24, 2024

That worked for me indeed.

@immanuelfodor
Copy link
Owner

Hurray! 🎉
I'll keep the issue open if somebody else runs into it, so they'll know of the workaround.
Maybe a detection of the theme could solve it for the long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants