Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-user): userManagement service scaffolding #1

Merged
merged 9 commits into from
Dec 21, 2021

Conversation

imione
Copy link
Owner

@imione imione commented Dec 21, 2021

  • create user-management application
  • add userModule
  • add database configuration
  • add configModule & refactor database config using configModule
  • add terminus for healthcheck endpoint
  • add graceful shutdown

@imione imione assigned imione and unassigned imione Dec 21, 2021
@imione
Copy link
Owner Author

imione commented Dec 21, 2021

MikroOrmModule disconnects database in OnApplicationShutdown hook

At the mo, graceful shutdown doesn't need to be implemented.
And if other infrastructures which are managed in lifecycle hook, they woud be better wrapped in specific module and managed into the module.

So, I won't add graceful shutdown at this time.

@imione imione marked this pull request as ready for review December 21, 2021 14:09
@imione imione merged commit 1e2ade6 into main Dec 21, 2021
@imione imione deleted the feat/app-user-management/scaffold branch December 21, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant