Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events Not Merging #76

Open
ilyg opened this issue Jun 17, 2019 · 7 comments
Open

Events Not Merging #76

ilyg opened this issue Jun 17, 2019 · 7 comments

Comments

@ilyg
Copy link

ilyg commented Jun 17, 2019

The tool is not merging the events that are similar/the same. When I toggle on or off no change happens even with those events which are supposed to merge.

For instance, my schedule shift is both on the attendance calendar and I have "invited" myself and so it should merge showing that it is, in essence, the same event.

This extension has worked for me outside of corporate and I'm sad that it's not working for me here!

Your aid is greatly appreciated.

Screen Shot 2019-06-17 at 9 04 49 AM

@gregschwartz
Copy link

gregschwartz commented Jun 21, 2019

Love this extension! Unfortunately Gcal probably pushed some changes, because I'm seeing the same issue:
Screen Shot 2019-06-21 at 10 52 52 AM

I even tried copying the green event to the blue calendar just now, to make sure the events are the same.

@ilyg
Copy link
Author

ilyg commented Jun 21, 2019 via email

@imightbeamy
Copy link
Owner

I've been trying to replicate what you're both seeing, but haven't been able too :(

Here are some questions that might help me get to the bottom of it:

  • If you copy those events to another week, do they merge?
  • Are you seeing other merged events, or are no events merging for you at all?
  • Can you open the javascript console and screenshot anything you see there?
    • You can do that in Chrome by going to "View" => "Developer" => "JavaScript Console".

@ilyg
Copy link
Author

ilyg commented Jul 1, 2019 via email

@gregschwartz
Copy link

No events are merging at all, on many different weeks, even after a fresh restart. JS console has something interesting!

events.user.js:157   Event merge is disabled

That code is:

setTimeout(() => chrome.storage.local.get('disabled', storage => {
  console.log(`Event merge is ${storage.disabled ? 'disabled' : 'enabled'}`);
  if (!storage.disabled) {
    const observer = new MutationObserver(init);
    observer.observe(document.querySelector('body'), { childList: true, subtree: true, attributes: true });
  }

  chrome.storage.onChanged.addListener(() => window.location.reload())
}), 10);

No clue why local storage would be disabled, here's the settings for gCal:
Screen Shot 2019-07-01 at 7 57 06 PM
Screen Shot 2019-07-01 at 7 57 36 PM

@cyberbit
Copy link

cyberbit commented Jul 8, 2019

Same issue here, this is a screenshot of my console:
image

@Xaxetrov
Copy link

Xaxetrov commented Jul 16, 2019

Events are merging in month view but not in some week views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants