Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the imgix swift library to have initializer that accepts no host parameter #45

Open
AbuBoo opened this issue Aug 2, 2023 · 0 comments

Comments

@AbuBoo
Copy link

AbuBoo commented Aug 2, 2023

Description:
When using the Swift Library to construct imgix URLs, you must include a host to initialize the imgix client. An image of the code block is included below.
https://assetmanager.imgix.net/Testing-%F0%9F%98%83.png

The suggestion would be to allow these URLs to be built using an input URL. Similar to what is being used in our current URL reconstruction library.
https://assetmanager.imgix.net/URlRecon.png

Problem:
Currently, Grailed is trying to use our library to build the URLs they will be listing in their IOS app using the Swift library. They are building these URLs using custom domains. So when building the host URL they would rather the client builder use the host that's already in the URL.

Suggested Solution:
To allow the URLs to accept a no-host input and grab the host name from the input URL.

Describe alternatives you've considered
For now, they can just use the imgixClient instance or use the URL reconstructor to ensure they get the correct URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant