From 90a2d3a44b2f71ceed2cc4215e8e96e5b29adc66 Mon Sep 17 00:00:00 2001
From: Michael Chadwick <michael.chadwick@gmail.com>
Date: Tue, 8 Oct 2024 09:39:47 -0700
Subject: [PATCH 1/5] remove program component render-modifier

---
 packages/frontend/app/components/program/overview.hbs | 8 +-------
 packages/frontend/app/components/program/overview.js  | 4 ++--
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/packages/frontend/app/components/program/overview.hbs b/packages/frontend/app/components/program/overview.hbs
index 2e988ea12c..1e03580c19 100644
--- a/packages/frontend/app/components/program/overview.hbs
+++ b/packages/frontend/app/components/program/overview.hbs
@@ -1,10 +1,4 @@
-<div
-  class="program-overview"
-  {{did-insert this.load @program}}
-  {{did-update this.load @program}}
-  data-test-program-overview
-  ...attributes
->
+<div class="program-overview" data-test-program-overview ...attributes>
   <h2>
     {{t "general.overview"}}
   </h2>
diff --git a/packages/frontend/app/components/program/overview.js b/packages/frontend/app/components/program/overview.js
index e1522215f5..7abe6431ab 100644
--- a/packages/frontend/app/components/program/overview.js
+++ b/packages/frontend/app/components/program/overview.js
@@ -11,8 +11,8 @@ export default class ProgramOverviewComponent extends Component {
   @tracked duration;
   @Length(2, 10) @tracked shortTitle;
 
-  @action
-  load() {
+  constructor() {
+    super(...arguments);
     this.duration = this.args.program.duration;
     this.shortTitle = this.args.program.shortTitle;
   }

From caa01d60ff8d08e1ce327d7b6e4adfe073229a3a Mon Sep 17 00:00:00 2001
From: Michael Chadwick <michael.chadwick@gmail.com>
Date: Tue, 8 Oct 2024 09:43:39 -0700
Subject: [PATCH 2/5] update lint-todo

---
 packages/frontend/.lint-todo | 2 --
 1 file changed, 2 deletions(-)

diff --git a/packages/frontend/.lint-todo b/packages/frontend/.lint-todo
index 439de8ca81..45c985048b 100644
--- a/packages/frontend/.lint-todo
+++ b/packages/frontend/.lint-todo
@@ -35,8 +35,6 @@ add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|cb6d7acb9879902b89a
 add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|2bdc98d02ac5ea2a4bd5bac6a0f9e880abafdcbe|1722902400000|1730682000000|1754006400000|app/components/learner-group/instructor-manager.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|4|4|4|170987df2d1e4c134a0ac459fc0bdd8dd91b9929|1722902400000|1730682000000|1754006400000|app/components/learner-group/root.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|5|4|5|4|7c59a55b95fd159dd99afa6b20e5f05b5b68def0|1722902400000|1730682000000|1754006400000|app/components/learner-group/root.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|66fe3cf991d61995cda5f5935874230700b5e21f|1722902400000|1730682000000|1754006400000|app/components/program/overview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|0bcfaa7865c6a954a5b5226ffe44ddc6c63945ba|1722902400000|1730682000000|1754006400000|app/components/program/overview.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|12f77ac1f8c43640397b771ba2c9830dd2041f23|1722902400000|1730682000000|1754006400000|app/components/program-year/collapsed-objectives.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|87dcba868bd23c9305b095ffbda9e90ab5b4918e|1722902400000|1730682000000|1754006400000|app/components/program-year/collapsed-objectives.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|b759467cf4c3dc1d7e39d4bed1d085d51090d363|1722902400000|1730682000000|1754006400000|app/components/program-year/objective-list-item-expanded.hbs

From e4d6de59514f72a8c8f7423f33c343e767cb0d50 Mon Sep 17 00:00:00 2001
From: Michael Chadwick <michael.chadwick@gmail.com>
Date: Tue, 8 Oct 2024 13:22:24 -0700
Subject: [PATCH 3/5] removed more render-modifiers

---
 packages/frontend/.lint-todo                          |  4 ++++
 .../components/program-year/objective-list-item.hbs   |  2 --
 .../components/program-year/objective-list-item.js    |  4 ++--
 .../app/components/program-year/objectives.hbs        |  7 +------
 .../app/components/program-year/objectives.js         | 11 ++++++++---
 5 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/packages/frontend/.lint-todo b/packages/frontend/.lint-todo
index 45c985048b..c100b36464 100644
--- a/packages/frontend/.lint-todo
+++ b/packages/frontend/.lint-todo
@@ -57,3 +57,7 @@ add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c0
 add|ember-template-lint|no-at-ember-render-modifiers|11|6|11|6|940005188b476a060b0e5d3f05baea24ba178878|1722902400000|1730682000000|1754006400000|app/components/reports/subject/new/session-type.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c01fe2ba15416673e52e91124|1722902400000|1730682000000|1754006400000|app/components/reports/subject/new/term.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|11|6|11|6|940005188b476a060b0e5d3f05baea24ba178878|1722902400000|1730682000000|1754006400000|app/components/reports/subject/new/term.hbs
+remove|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|fc55335d86e2b3d97a0614f6c046ba360820801c|1722902400000|1730682000000|1754006400000|app/components/program-year/objective-list-item.hbs
+remove|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|12443b4ba50f603e3c3af3d9e10ce840e7b67d9e|1722902400000|1730682000000|1754006400000|app/components/program-year/objective-list-item.hbs
+remove|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|286929067e02096dda5597efc45c876218621874|1722902400000|1730682000000|1754006400000|app/components/program-year/objectives.hbs
+remove|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|f37fd8ee0b117114a09137593ed6f113b2c80806|1722902400000|1730682000000|1754006400000|app/components/program-year/objectives.hbs
diff --git a/packages/frontend/app/components/program-year/objective-list-item.hbs b/packages/frontend/app/components/program-year/objective-list-item.hbs
index 61b5bf0f38..977675a84b 100644
--- a/packages/frontend/app/components/program-year/objective-list-item.hbs
+++ b/packages/frontend/app/components/program-year/objective-list-item.hbs
@@ -6,8 +6,6 @@
     {{if this.isManaging 'is-managing'}}
     {{unless @programYearObjective.active 'is-inactive'}}"
   data-test-program-year-objective-list-item
-  {{did-insert this.load @programYearObjective}}
-  {{did-update this.load @programYearObjective}}
 >
   <button
     class="expand-row grid-item"
diff --git a/packages/frontend/app/components/program-year/objective-list-item.js b/packages/frontend/app/components/program-year/objective-list-item.js
index 94e477441a..3fb1c0cc53 100644
--- a/packages/frontend/app/components/program-year/objective-list-item.js
+++ b/packages/frontend/app/components/program-year/objective-list-item.js
@@ -21,8 +21,8 @@ export default class ProgramYearObjectiveListItemComponent extends Component {
   @tracked termsBuffer = [];
   @tracked selectedVocabulary;
 
-  @action
-  load() {
+  constructor() {
+    super(...arguments);
     this.title = this.args.programYearObjective.title;
   }
 
diff --git a/packages/frontend/app/components/program-year/objectives.hbs b/packages/frontend/app/components/program-year/objectives.hbs
index 76e25400a6..d630384d5c 100644
--- a/packages/frontend/app/components/program-year/objectives.hbs
+++ b/packages/frontend/app/components/program-year/objectives.hbs
@@ -1,9 +1,4 @@
-<section
-  class="program-year-objectives"
-  {{did-insert this.load @programYear}}
-  {{did-update this.load @programYear @programYear.programYearObjectives}}
-  data-test-program-year-objectives
->
+<section class="program-year-objectives" data-test-program-year-objectives>
   <div class="header">
     {{#if this.showCollapsible}}
       <div>
diff --git a/packages/frontend/app/components/program-year/objectives.js b/packages/frontend/app/components/program-year/objectives.js
index 3c5fccda1f..bc4bc5d1cf 100644
--- a/packages/frontend/app/components/program-year/objectives.js
+++ b/packages/frontend/app/components/program-year/objectives.js
@@ -21,11 +21,16 @@ export default class ProgramYearObjectivesComponent extends Component {
     return this.objectiveCount > 0;
   }
 
-  @action
-  load(element, [programYear]) {
-    this.objectiveCount = programYear.hasMany('programYearObjectives').ids().length;
+  constructor() {
+    super(...arguments);
+    this.objectiveCount = this.args.programYear.hasMany('programYearObjectives').ids().length;
   }
 
+  // @action
+  // load(element, [programYear]) {
+  //   this.objectiveCount = programYear.hasMany('programYearObjectives').ids().length;
+  // }
+
   saveNewObjective = dropTask(async (title) => {
     const programYearObjectives = await this.args.programYear.programYearObjectives;
     const position = programYearObjectives.length

From 5ea34ab14a166957c400811172eaaccb299c970c Mon Sep 17 00:00:00 2001
From: Michael Chadwick <michael.chadwick@gmail.com>
Date: Thu, 17 Oct 2024 11:27:48 -0700
Subject: [PATCH 4/5] compact lint-todo

---
 packages/frontend/.lint-todo | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/packages/frontend/.lint-todo b/packages/frontend/.lint-todo
index c100b36464..83360c866b 100644
--- a/packages/frontend/.lint-todo
+++ b/packages/frontend/.lint-todo
@@ -39,10 +39,6 @@ add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|12f77ac1f8c43640397
 add|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|87dcba868bd23c9305b095ffbda9e90ab5b4918e|1722902400000|1730682000000|1754006400000|app/components/program-year/collapsed-objectives.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|b759467cf4c3dc1d7e39d4bed1d085d51090d363|1722902400000|1730682000000|1754006400000|app/components/program-year/objective-list-item-expanded.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|c4f87a15e0dbf28e3a3b95d7b8259a419f93b29d|1722902400000|1730682000000|1754006400000|app/components/program-year/objective-list-item-expanded.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|fc55335d86e2b3d97a0614f6c046ba360820801c|1722902400000|1730682000000|1754006400000|app/components/program-year/objective-list-item.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|12443b4ba50f603e3c3af3d9e10ce840e7b67d9e|1722902400000|1730682000000|1754006400000|app/components/program-year/objective-list-item.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|286929067e02096dda5597efc45c876218621874|1722902400000|1730682000000|1754006400000|app/components/program-year/objectives.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|f37fd8ee0b117114a09137593ed6f113b2c80806|1722902400000|1730682000000|1754006400000|app/components/program-year/objectives.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c01fe2ba15416673e52e91124|1722902400000|1730682000000|1754006400000|app/components/reports/subject/new/academic-year.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|11|6|11|6|940005188b476a060b0e5d3f05baea24ba178878|1722902400000|1730682000000|1754006400000|app/components/reports/subject/new/academic-year.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c01fe2ba15416673e52e91124|1722902400000|1730682000000|1754006400000|app/components/reports/subject/new/competency.hbs
@@ -57,7 +53,3 @@ add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c0
 add|ember-template-lint|no-at-ember-render-modifiers|11|6|11|6|940005188b476a060b0e5d3f05baea24ba178878|1722902400000|1730682000000|1754006400000|app/components/reports/subject/new/session-type.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c01fe2ba15416673e52e91124|1722902400000|1730682000000|1754006400000|app/components/reports/subject/new/term.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|11|6|11|6|940005188b476a060b0e5d3f05baea24ba178878|1722902400000|1730682000000|1754006400000|app/components/reports/subject/new/term.hbs
-remove|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|fc55335d86e2b3d97a0614f6c046ba360820801c|1722902400000|1730682000000|1754006400000|app/components/program-year/objective-list-item.hbs
-remove|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|12443b4ba50f603e3c3af3d9e10ce840e7b67d9e|1722902400000|1730682000000|1754006400000|app/components/program-year/objective-list-item.hbs
-remove|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|286929067e02096dda5597efc45c876218621874|1722902400000|1730682000000|1754006400000|app/components/program-year/objectives.hbs
-remove|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|f37fd8ee0b117114a09137593ed6f113b2c80806|1722902400000|1730682000000|1754006400000|app/components/program-year/objectives.hbs

From b1dacf0f289b1048546c803f2abaeb52308ef898 Mon Sep 17 00:00:00 2001
From: Michael Chadwick <michael.chadwick@gmail.com>
Date: Mon, 21 Oct 2024 10:14:38 -0700
Subject: [PATCH 5/5] changed component attribute to getter

---
 .../app/components/program-year/objectives.js         | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/packages/frontend/app/components/program-year/objectives.js b/packages/frontend/app/components/program-year/objectives.js
index bc4bc5d1cf..985e05364e 100644
--- a/packages/frontend/app/components/program-year/objectives.js
+++ b/packages/frontend/app/components/program-year/objectives.js
@@ -11,7 +11,6 @@ export default class ProgramYearObjectivesComponent extends Component {
 
   @tracked newObjectiveEditorOn = false;
   @tracked newObjectiveTitle;
-  @tracked objectiveCount;
 
   get showCollapsible() {
     return this.hasObjectives && !this.isManaging;
@@ -21,16 +20,10 @@ export default class ProgramYearObjectivesComponent extends Component {
     return this.objectiveCount > 0;
   }
 
-  constructor() {
-    super(...arguments);
-    this.objectiveCount = this.args.programYear.hasMany('programYearObjectives').ids().length;
+  get objectivesCount() {
+    return this.args.programYear.hasMany('programYearObjectives').ids().length;
   }
 
-  // @action
-  // load(element, [programYear]) {
-  //   this.objectiveCount = programYear.hasMany('programYearObjectives').ids().length;
-  // }
-
   saveNewObjective = dropTask(async (title) => {
     const programYearObjectives = await this.args.programYear.programYearObjectives;
     const position = programYearObjectives.length