Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form Based Auth on Demo User Password Strength Tool on Initial User Entry is Missing #4303

Open
dartajax opened this issue Sep 11, 2019 · 3 comments · May be fixed by ilios/frontend#8176
Open

Form Based Auth on Demo User Password Strength Tool on Initial User Entry is Missing #4303

dartajax opened this issue Sep 11, 2019 · 3 comments · May be fixed by ilios/frontend#8176
Assignees
@michaelchadwick
Labels
Enhancement UI User Facing Interface Issue

Comments

@dartajax
Copy link
Member

Currently, the password strength indicator only appears when you are updating or resetting a user's password.

I entered this user with an invalid password "123" - minimum is apparently 5 char when you see the strength indicator.

image

The password initially entered now is run through the strength indicator which captures the fact that the initial password was only three chars long and is invalid.

image
@dartajax dartajax changed the title User Password Strength Tool on Initial User Entry Form Based Auth on Demo User Password Strength Tool on Initial User Entry is Missing Sep 11, 2019
@dartajax dartajax transferred this issue from ilios/ilios Jan 23, 2020
@jrjohnson jrjohnson transferred this issue from ilios/frontend Aug 25, 2022
@jrjohnson jrjohnson added the UI User Facing Interface Issue label Aug 25, 2022
@jrjohnson jrjohnson removed their assignment Jul 27, 2023
@michaelchadwick michaelchadwick self-assigned this Sep 26, 2024
@michaelchadwick
Copy link
Contributor

@dartajax Do we just want the "check for length" validation? Or do we also want the password strength thing?

@michaelchadwick
Copy link
Contributor

@stopfstedt @jrjohnson Adding the length validation to the <NewUser> component is easy enough, but I feel like the password strength thing, since it's currently baked into the <UserProfileBio> component, should probably be pulled out to a service or something if it's going to be used in two different places.

@michaelchadwick michaelchadwick linked a pull request Oct 3, 2024 that will close this issue
Draft
@michaelchadwick
Copy link
Contributor

NTS: going forward with validation on <NewUser>, but make the password validation into a component so that it can be used in both (and possibly more?) places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelchadwick michaelchadwick

Labels
Enhancement UI User Facing Interface Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve New User password validation michaelchadwick/ilios-frontend
3 participants
@jrjohnson @michaelchadwick @dartajax