Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specifications of exit codes for the Guider launcher #263

Open
elfring opened this issue Sep 26, 2021 · 1 comment
Open

Fix specifications of exit codes for the Guider launcher #263

elfring opened this issue Sep 26, 2021 · 1 comment
Assignees
Labels

Comments

@elfring
Copy link

elfring commented Sep 26, 2021

I suggest to correct two places in the Guider launcher script.

  • A)

                    echo "[Error] fail to find python"
                    exit

    The bash manual provides the following information.

                  … If n is omitted, the exit status is that of the last command executed. …
    

    I doubt that the exit status from a successful execution of an echo command (for an error message) is appropriate here.
    Thus I would prefer to use exit 1 instead.

  • B)

    $PYTHON -m guider $*
    
    exit 0

    I would prefer that an erroneous execution of the Guider program call will be indicated by a corresponding error code.
    Would you like to delete the statement “exit 0” then?

@iipeace
Copy link
Owner

iipeace commented Sep 27, 2021

I agree with you :)

@iipeace iipeace self-assigned this Sep 27, 2021
@iipeace iipeace added the bug label Sep 27, 2021
iipeace added a commit that referenced this issue Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants