Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-the-fly preprocessing? #26

Open
perrette opened this issue Oct 14, 2024 · 4 comments
Open

on-the-fly preprocessing? #26

perrette opened this issue Oct 14, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request preprocessing Processing data to feed into rime(X) rimeX

Comments

@perrette
Copy link
Collaborator

add an option to add a custom function to preprocess climate variables before inputting it into rime preprocessing?

[first posted in https://github.com//issues/23#issue-2473505220]

@perrette perrette added enhancement New feature or request rimeX labels Oct 14, 2024
@perrette perrette self-assigned this Oct 14, 2024
@perrette perrette added the preprocessing Processing data to feed into rime(X) label Oct 14, 2024
@NiklasSchwind
Copy link
Collaborator

NiklasSchwind commented Oct 15, 2024

The thought behind this idea is to save some disk space for the user by not having to first process the default indicators into the indicator you want to emulate (e.g. daily tasmax into yearly maximum tasmax if you want to emulate yearly maximum tasmax) and then apply the package but that the package can include such processing steps (and thus emulate yearly maximum tasmax from daily tasmax in our example). Including the preprocessing of the variable in the package would omit the need to save yearly maximum tasmax simulations as an in-between step.

However, I would say it is a low priority and I wouldn't implement it if it becomes complicated or makes the code ugly.

@perrette
Copy link
Collaborator Author

Hi Niklas, I am not sure I follow you 100%. In my mind I understood this issue as adding an option to do some of the work behind the scene (like data download and preprocessing), instead of explicitly executing all these steps with dedicated commands. The way I figured it would not save any disk space compared to doing it directly. But we can discuss this elsewhere possibly. Anyway, I'll mark it as low priority and possibly out of this milestone, right? (more as an unspecified rimeX issue)

@perrette perrette removed this from the Fall 2024 Deliverables (rimeX) milestone Oct 15, 2024
@NiklasSchwind
Copy link
Collaborator

NiklasSchwind commented Oct 18, 2024

Your interpretation might be a good idea to explore as well! However, I meant to enable users to write their own preprocessing function that e.g. preprocesses daily tasmax to TXx and includes it in the configuration so that rimeX automatically applies this function to the tasmax data to produce the TXx data, then produces the records for TXx and afterward automatically delete the TXx data again. But, I think we can just not do this, maybe it complicates things too much. The alternative is to preprocess tasmax first into TXx outside of rimeX and then apply rimeX to TXx. This is anyway a low priority adjustment imo.

@perrette
Copy link
Collaborator Author

We'll see clearer when we have built-in preprocessing for this in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preprocessing Processing data to feed into rime(X) rimeX
Projects
None yet
Development

No branches or pull requests

2 participants