Codecov Report

Attention: Patch coverage is 0.58480% with 170 lines in your changes are missing coverage. Please review.

Project coverage is 91.8%. Comparing base (27cd54e) to head (96c5cd1).

❗ Current head 96c5cd1 differs from pull request most recent head 67181b2. Consider uploading reports for the commit 67181b2 to get more accurate results

@@           Coverage Diff           @@
##            main    #810     +/-   ##
=======================================
- Coverage   95.4%   91.8%   -3.6%     
=======================================
  Files         46      47      +1     
  Lines       4354    4524    +170     
=======================================
  Hits        4156    4156             
- Misses       198     368    +170     

Hi @gidden, please clarify for me: I thought we wanted to have the tutorials be part of message-ix-models. Was this decision revised? Should I still set up a docs page etc for tutorials in message-ix-models?

Hey @glatterf42 - good questions. Yes, in reviewing this PR and related work with @ywpratama yesterday, we realized that his add_dac() functionality was more generic and could be applied at a high level repo (similar to add_years() here). That is at least the proposal for now, which we can discuss once the PR is finalized.

So in short, no need to add tutorials page yet to message-ix-models

@glatterf42 and @ywpratama - this PR now has the content added to it that is expected. It would be useful if the two of you could sit down and discuss how to best add relevant tests for this so it can be merged.

@ywpratama there should be already available documentation for how to pass the code quality checks