-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage of secrets for PRs from forks #50
Comments
We may also implement the same approach for message_data, although the concerns are less there because it is a private repository and we control who has access/is able to fork and open PRs. |
Sorry, maybe this is a duplicate of #21. |
Thanks for opening this. Just commenting here to share that we've had a similar experience with another repository (climate assessment) with secrets, where we did not find a good solution (within time constraints), and just continued working using a branching workflow. |
Add documentation on the land-use emulator
Add documentation on the land-use emulator
For full requests from forks (e.g. #49), the "pytest" CI workflow currently fails. This is because it depends on secrets:
GitHub does not pass secrets to PRs from forks. This is because any malicious third party could fork, write code that 'steals' the secret, and open a PR; then the automatically-triggered workflow would activate the malicious code.
It is possible (we're not sure) that we could work around this using GitHub's environments feature. The idea is that, for each environment, we can set a maintainer (i.e. member of @iiasa/messageix-devs) who must give approval before particular workflows will run. Secrets can be stored within an environment (rather than for the repo as a whole).
To resolve this issue, investigate and, if viable, implement this solution.
Current workarounds:
The text was updated successfully, but these errors were encountered: