Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to have more control on event ExitFullScreen ? #83

Open
MonsieurBuffle opened this issue Feb 24, 2020 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@MonsieurBuffle
Copy link

MonsieurBuffle commented Feb 24, 2020

Hi guys !,
I'm developing an application with some videos in it. Thanks to you, we have a pretty simple way to handle videos :)

Problem
My application was designed and locked is PORTRAIT mode.
When someone wants to see a video in fullscreen and when he clicks on the fullscreen button, I have to change the screen orientation behavior (thanks too the ScreenOrientation API exposed by expo :D ).
It's pretty ok to enter in fullscreen mode, but when the user click on the button to exit fullscreen mode, the video is exiting, and just quickly after it, we can see the application switching from landscape to portrait. It's pretty ugly :/

Describe the solution you'd like
Is it possible to listen the "click" on the ExitFullscreen button, to change the orientation before the video really exit fullscreen mode ?

Describe alternatives you've considered
I didn't find alternatives, or different way to handle my problem :/

Additional context
Working with:

  • Expo sdk 36.0.0
  • expo-video-player 1.5.7

Thanks ! :)

@ihmpavel
Copy link
Owner

Hi, right now there is no way to detect the behaviour you want to archieve. (I have the same problem also in my app :D.)

I do not have plans to implementing this feature to the library soon, but I am open for any PRs.

I will leave this open for now.

@ihmpavel ihmpavel added the enhancement New feature or request label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants