Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: one less tmp use case #1715

Merged
merged 1 commit into from
Feb 27, 2025
Merged

refactor: one less tmp use case #1715

merged 1 commit into from
Feb 27, 2025

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Feb 24, 2025

Related to #1328

@maelle maelle requested a review from schochastics February 24, 2025 09:39
Copy link
Contributor

aviator-app bot commented Feb 24, 2025

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

arrow.mode,
\(x) switch(
x,
"<" = 1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be the first time I find vertical alignment useful 😸

@maelle maelle merged commit cd45428 into main Feb 27, 2025
6 checks passed
@maelle maelle deleted the minus-tmp branch February 27, 2025 09:28
@schochastics
Copy link
Contributor

schochastics commented Feb 27, 2025

@maelle it seems this change makes my PRs fail for R 4.0? https://github.com/igraph/rigraph/actions/runs/13567024838/job/37925237675?pr=1720 Do you think this is temporary (or random?) or do we need to switch to function(x)? Dont recall this error for this PR

@schochastics
Copy link
Contributor

testing with #1722

@maelle
Copy link
Contributor Author

maelle commented Feb 27, 2025

oops so sorry

@schochastics
Copy link
Contributor

no worries, should be fixed now. I also missed it

@maelle
Copy link
Contributor Author

maelle commented Feb 27, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants