Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How useful is graph_from_graphdb()? #1712

Closed
maelle opened this issue Feb 24, 2025 · 7 comments · Fixed by #1732
Closed

How useful is graph_from_graphdb()? #1712

maelle opened this issue Feb 24, 2025 · 7 comments · Fixed by #1732
Labels
lifecycle Deprecating old APIs upkeep maintenance, infrastructure, and similar

Comments

@maelle
Copy link
Contributor

maelle commented Feb 24, 2025

Just noticed this function in R/foreign.R, that does not have any test. In the CRAN mirror I only see it in igraph repo https://github.com/search?q=graph_from_graphdb+user%3Acran&type=code&ref=advsearch

Is it useful or should it be deprecated?

@maelle maelle added the lifecycle Deprecating old APIs label Feb 24, 2025
@maelle maelle changed the title How useful is graph_from_graphdb() How useful is graph_from_graphdb()? Feb 24, 2025
@szhorvat
Copy link
Member

It should be kept, this gives access to a large database for testing isomorphism algorithms.

@maelle
Copy link
Contributor Author

maelle commented Feb 24, 2025

Ok, then it should be tested.

@maelle maelle added upkeep maintenance, infrastructure, and similar and removed lifecycle Deprecating old APIs labels Feb 24, 2025
@schochastics
Copy link
Contributor

Is this db still available somewhere? because the current base default (http://cneurocvs.rmki.kfki.hu/graphdb/gzip) does not exist anymore @szhorvat

@szhorvat
Copy link
Member

szhorvat commented Mar 3, 2025

The C docs are usually more up to date, and you can find the link to the database there: https://igraph.org/c/html/latest/igraph-Foreign.html#igraph_read_graph_graphdb

The link is: https://mivia.unisa.it/datasets/graph-database/arg-database/

Today this site is down but just a couple of weeks ago when @maelle was asking about this it was working fine. There's no direct download link to the files. Instead, the whole database is downloadable as a zip file.

@schochastics
Copy link
Contributor

Downloading the whole database is not optimal though. The version I downloaded is 500MB and unzipped 1GB. Thats why I wondered if we should host it ourselves as proposed in #1732

@szhorvat
Copy link
Member

szhorvat commented Mar 4, 2025

I'm so sorry both, I did not read the original question carefully enough. I assumed (without looking) that this R function behaves similarly to the C importer, i.e. that it imports from a user-specified file.

That's not the case: it is connected to an online database and it downloads from there. I'm not sure if that is very usable for isomorphism testing, given how slow downloads can be ... A more practical way to use this database for testing is to have an offline copy that is quick to load.

Given what the function does, perhaps it is not as useful as I claimed. It could perhaps be moved to another package in the long term? What do you think?

If it's kept, it's reasonable to do what @schochastics is doing here and host the data ourselves. Does the base parameter support a local path instead of an URL? That might be quite useful.

I'm sorry about the confusion again, it's been a busy couple of weeks.

@schochastics
Copy link
Contributor

No worries. I will make sure the function supports local paths. Then we can think about removing this function later. Not sure how many users we have that do isomorphism testing in R ;-)

@maelle maelle added the lifecycle Deprecating old APIs label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle Deprecating old APIs upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants