-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide tutorial as a notebook #667
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
Relevant docs from Readthedocs re Jupyter integration are here. Personally, I'd be in favour of converting the tutorial to Jupyter notebooks, but I would not try to maintain two versions in parallel (a Jupyter notebook and a non-interactive version). Jupytext seems to be a good candidate for managing the source of the notebook in a VCS-friendly format and then we can generate the notebook from it at build time. Alternatively, there are many Markdown variants that we could use. If the tutorial is code-heavy, Jupytext is a better option, otherwise we could use Markdown. |
I can give this a go. I'll aim to open a PR against |
No reason this can't go in the 0.10.x series IMO. Let's try not to put things unnecessarily on |
I tried playing with it a little bit. The easiest would be to convert the The tutorial has several changes in |
Why does a script that converts the tutorial to a notebook depend on the contents of the tutorial?
If you want 0.11 earlier, then you can help out with implementing the necessary changes on the C side. |
I think it would be best to decouple major python igraph releases from C ones. Why not release python igraph 0.11 with the mpl changes (which are important) based on the current C igraph 0.10? This would give everyone the most flexibility. Opinions? |
I'd just like to say, I am becoming quite busy with my lab so reimplementing things twice is not really feasible. If you want to better understand why that is affected by the mpl change, please take a look at sphinx gallery and how we use it in our docs. I'm also happy to wait until develop has been released, it's not urgent anyway. Thank you, unfortunately I really have too little time to help with the C core at the moment. |
Any comments on this @ntamas and @iosonofabio ? I understand @iosonofabio's concerns and motivation for wanting the next release soon and I agree with him. I think this would be a good solution with virtually no drawback (other than a bit of a version confusion for some people) that would give us the flexibility we need. Trying to keep python-igraph and C/igraph in lockstep will always be inconvenient for either one side or the other. It is now the second time that python-igraph accumulated C-independent breaking changes that would be very useful (to users) to release, not to mention that not releasing them hinders development. |
For the record: we have discussed this with @szhorvat online and the decision was to move forward with |
That's great, I agree we might have been a little uptight on that issue given that rigraph is already decoupled. I've made a draft PR exploring the use of
I've also looked into I've also found https://github.com/QuantEcon/sphinxcontrib-jupyter which is one step closer to what we want, i.e. conversion of an existing rst file into a notebook without having to rewrite the whole thing. The issue there is that it's unmaintained since 2020. Nonetheless, the backing organisation (https://quantecon.org/) is alive and kicking, co-run by US and Aussie folks, and under the numfocus umbrella. It would be conceivable to link up with them and see how much they care about that repo. Any comments? |
I guess that the easiest solution would be to avoid using code blocks in The cross-referencing stuff seems to be a pain to deal with, but we will need cross-referencing to make stuff user-friendly, so I'd rather let go the idea of converting the tutorial to a notebook if it causes so many complications down the road. It would be great if you could reach out to QuantEcon to see if the extension is maintained or whether it works with recent Sphinx versions at all. There were a few API changes in Sphinx 7 that might cause problems. |
It would be nice to provide the tutorial as a Jupyter notebook, so people can directly evaluate code without having to copy it first. Is this easy to do @iosonofabio ?
The text was updated successfully, but these errors were encountered: