-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement react-autosuggest alternative #2170
Comments
Hi, sir @LMulvey Thanks. |
Hey @MuhammadAakash, I haven't looked at https://github.com/downshift-js/downshift too deeply, but at first glance it looks like a good, maintained alternative to switch to. Feel free to take this on and investigate further! |
Hi @MuhammadAakash is there any progress on this issue? I'd love to work on it |
Hi @pauluzo. |
@pauluzo |
@MuhammadAakash thanks. I'll reach out on slack. |
@julianguyen do you know of any progress that has been made on this? |
No progress @lucas-codes-stuff ! You can start from scratch here! |
Hi If this issue is resolved or not. |
Hi, Can you assign this issue to me? I am new to open source and would like to work on this. |
Description
react-autosuggest
is no longer maintained and has deprecated code that conflicts with our testing utilities, React Testing Library (@testing-library/react
).react-autosuggest
still checks forevent.keyCode
, which is long since deprecated. testing-library/user-event stopped supporting as of v14 and now overwrites keyCode to0
(only to support React's SyntheticEvents which expect a value for keyCode).There are many alternatives out there but I would personally suggest
downshift
as it is well-maintained, well-supported, and quite scalable. The learning curve to get everything up-and-running can take a bit, but once you have your components established, it "just works". Plus, it has the benefit of being created and maintained by Kent C. Dodds, the creator/maintainer of React Testing Library.Reproduction Steps
See #2166 discussion for more details
Screenshots
Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.
Check out our Picking Up Issues guide if you haven't already!
The text was updated successfully, but these errors were encountered: