Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistake in the input of structured_energy. #2

Open
dhruvdcoder opened this issue Mar 11, 2021 · 0 comments
Open

Mistake in the input of structured_energy. #2

dhruvdcoder opened this issue Mar 11, 2021 · 0 comments
Assignees
@dhruvdcoder @leejayyoon @purujitgoyal @haogaobill
Labels
bug Something isn't working

Comments

@dhruvdcoder
Copy link
Collaborator

https://github.com/dhruvdcoder/structured_prediction_baselines/blob/8134512b1765198a79be6b4d82d6bc496da42b30/structured_prediction_baselines/modules/structured_energy/structured_energy.py#L32

I think we need to pass x instead of y in the input to forward. The energy does not need two sets of y values. It might need x or it might not but it does not need y.
@dhruvdcoder dhruvdcoder added the bug Something isn't working label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvdcoder dhruvdcoder

@leejayyoon leejayyoon

@purujitgoyal purujitgoyal

@haogaobill haogaobill

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dhruvdcoder @leejayyoon @purujitgoyal @haogaobill