-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate all volume and intersection functions #10
Comments
Do we want to unify all intersections and Volumes under single function? Or do we have 'if conditions' inside each one to revert to hard version based on beta value? |
I meant the latter. Note that this is a situation where the functional interface and class-based interface can (and should) actually be different. For example, the functional interface will include an "if" statement based on the variance (for example), but a class will assign the correct branch during initialization. (Maybe this is a premature optimization though.) |
We can leave this open and come back to it when we have a better idea about whether the optimization is needed or not. |
Add an example in the usage example notebooks. |
Trang will address this in the upcoming PR |
I think it would make sense to consolidate all volume (and intersection) functions into a single one, where if the variance is zero we revert to the "hard" versions of these functions.
The text was updated successfully, but these errors were encountered: