Skip to content

Commit baf5e3c

Browse files
committed
empty arrays fixed
1 parent efcfedf commit baf5e3c

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

src/ClickHouseSQLParser.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -867,6 +867,7 @@ public function parseCreateTableSql($create_full)
867867
return $eng_arr;
868868
}
869869

870+
$names = $parse_fields = [];
870871
if (!empty($create_fields)) {
871872
$fields_arr = $this->parseCreateFields($create_fields);
872873
if (\is_array($fields_arr)) {

tests/src/ClickHouseFunctionsTest.php

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -617,14 +617,18 @@ public function testGetTableInfo()
617617
//send async request
618618
$ch->toSlot("tabinfo")->getTableInfo($tbl, 10);
619619

620-
$arr = $ch->getTableInfo($tbl, 0);
621-
$this->assertArrayHasKey('table_name', $arr);
622-
$this->assertEquals($tbl, $arr['table_name']);
623-
$this->assertArrayNotHasKey('engine', $arr);
624-
$this->assertArrayNotHasKey('create', $arr);
625-
$this->assertArrayNotHasKey('system.merges', $arr);
626-
$this->assertArrayNotHasKey('system.replicas', $arr);
627-
$this->assertArrayNotHasKey('system.parts', $arr);
620+
try {
621+
$arr = $ch->getTableInfo($tbl, 0);
622+
$this->assertArrayHasKey('table_name', $arr);
623+
$this->assertEquals($tbl, $arr['table_name']);
624+
$this->assertArrayNotHasKey('engine', $arr);
625+
$this->assertArrayNotHasKey('create', $arr);
626+
$this->assertArrayNotHasKey('system.merges', $arr);
627+
$this->assertArrayNotHasKey('system.replicas', $arr);
628+
$this->assertArrayNotHasKey('system.parts', $arr);
629+
} catch(\Exception $e) {
630+
echo "error TableInfo for $tbl level 0\n";
631+
}
628632

629633
$arr = $ch->getTableInfo($tbl, 1);
630634
$this->assertArrayHasKey('table_name', $arr);

0 commit comments

Comments
 (0)