Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmpsb #114

Open
tcpipchip opened this issue Sep 8, 2022 · 7 comments
Open

cmpsb #114

tcpipchip opened this issue Sep 8, 2022 · 7 comments

Comments

@tcpipchip
Copy link

Sir,
can you verify why freeze ?

and

STOSB and LODSB not increment DI/SI, but decrement only.
Btw: no changes modifyng CLD or STD

:(

@idrisT11
Copy link
Owner

idrisT11 commented Sep 8, 2022

Sir,

For STOSB, LODSB and MOVSB, we've just fixed the issue. Same goes with CLD and STD. It should be fine now.

In case of CMPSB/W and SCASB/W, I've just noticed that even though we had programmed those instructions into the compiler, we hadn't yet implemented them in the emulator =/. The application freezes because it is unable to determine what to do as CMPSB has not been implemented in the emulator.

We will be working on this issue.

Thanks for your remarks ! Don't be shy pointing out other issue, it helps a lot .

@tcpipchip
Copy link
Author

thank you so much!
Other BUG is DEC CX, first time is already setting the FLAG Z

mov cx,10
dec cx ; here is setting the flag Z :(
jz xxxx

then i had to make this
dec cx
cmp cx, 0
jz xxxx

@tcpipchip
Copy link
Author

i suggest the Variables option show whole variable, not only the first byte...
and...update it...not only show the initial value...

@idrisT11
Copy link
Owner

idrisT11 commented Sep 9, 2022

I corrected the Bug relating to DEC, there were other instructions that had a similar issue with the flags (like INC, OR). I verified the other instructions and the problem seems to be fixed. (Btw: I did not yet fixed this flag issue for the instructions MUL and DIV. I will be working on it now).

And yes, for the variables, this has to be also fixed. We will do our best.

@tcpipchip
Copy link
Author

Thank you!

Fantastic!

Soon i will report more tests :)

@idrisT11
Copy link
Owner

So CMPSB and SCASB are now implemented in the emulator. I will be working on correcting other bugs. Let me know if you have something to report or a feature to add.

@tcpipchip
Copy link
Author

yes!!!!!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants